-
Notifications
You must be signed in to change notification settings - Fork 286
feat(cloud_sql): Add samples for Google/Customer-managed CAS instances. #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
glasnt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review, pending CI test results (may not pass, privateca tests need to skip application tests, may also apply here)
Any requested changes also should be reviewed for relevance to other instances in this PR (there are six files, I didn't duplicate the same comment six times, for example.)
|
/gcbrun |
BTW, I updated the description to indicate these samples will be included in gcp public doc. We have separate public docs for different DB types, so I assumed we need different files for that. And I see we do so for postgres_instance_ssl_cert, mysql_instance_ssl_cert, and sqlserver_instance_ssl_cert |
|
Friendly ping. Thanks. |
|
/gcbrun |
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
…s. (terraform-google-modules#842) * feat(cloud_sql): Add samples for Google/Customer-managed CAS instances. * feat(cloud_sql): improve the samples for customer-managed CAS CA instances. * resolve some review comments * Add edition to make mysql and pg examples work * fix lint issues.
Description
Fixes #410627056
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform apply(See b/410627056#comment2)terraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review