Skip to content

Conversation

@feng-zhe
Copy link
Contributor

@feng-zhe feng-zhe commented Apr 15, 2025

Description

Fixes #410627056

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

  • I have performed tests described in the Contributing guide:

    • Tests pass: terraform apply (See b/410627056#comment2)
    • Lint pass: terraform fmt check

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@feng-zhe feng-zhe requested review from a team as code owners April 15, 2025 22:15
@snippet-bot
Copy link

snippet-bot bot commented Apr 15, 2025

Here is the summary of changes.

You are about to add 21 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@glasnt glasnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review, pending CI test results (may not pass, privateca tests need to skip application tests, may also apply here)

Any requested changes also should be reviewed for relevance to other instances in this PR (there are six files, I didn't duplicate the same comment six times, for example.)

@glasnt
Copy link
Contributor

glasnt commented Apr 16, 2025

/gcbrun

@feng-zhe
Copy link
Contributor Author

Initial review, pending CI test results (may not pass, privateca tests need to skip application tests, may also apply here)

Any requested changes also should be reviewed for relevance to other instances in this PR (there are six files, I didn't duplicate the same comment six times, for example.)

BTW, I updated the description to indicate these samples will be included in gcp public doc. We have separate public docs for different DB types, so I assumed we need different files for that. And I see we do so for postgres_instance_ssl_cert, mysql_instance_ssl_cert, and sqlserver_instance_ssl_cert

@feng-zhe feng-zhe requested a review from glasnt April 16, 2025 21:15
@feng-zhe
Copy link
Contributor Author

Friendly ping. Thanks.

@iennae
Copy link
Contributor

iennae commented Apr 18, 2025

/gcbrun

@iennae
Copy link
Contributor

iennae commented Apr 18, 2025

/gcbrun

2 similar comments
@iennae
Copy link
Contributor

iennae commented Apr 18, 2025

/gcbrun

@iennae
Copy link
Contributor

iennae commented Apr 21, 2025

/gcbrun

@iennae iennae merged commit c8a861f into terraform-google-modules:main Apr 22, 2025
5 checks passed
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
…s. (terraform-google-modules#842)

* feat(cloud_sql): Add samples for Google/Customer-managed CAS instances.

* feat(cloud_sql): improve the samples for customer-managed CAS CA instances.

* resolve some review comments

* Add edition to make mysql and pg examples work

* fix lint issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants