-
Notifications
You must be signed in to change notification settings - Fork 286
feat: add sample for flex reservation #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/gcbrun |
|
/gcbrun |
|
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
|
/gcbrun |
|
/gcbrun |
Co-authored-by: Andrew Peabody <[email protected]>
|
/gcbrun |
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @raushan2016!
A few nits / best practices, please also fill out the Intended location, etc, in the PR description.
|
/gcbrun |
|
/gcbrun |
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @raushan2016!
) * Adding sample for flex reservation * Fix spacing * Add provider as google-beta * formatting * Moving to separate folder and adding test skip file * fmt * Update gke/standard/zonal/dws/main.tf Co-authored-by: Andrew Peabody <[email protected]> * fmt * Validated change --------- Co-authored-by: Andrew Peabody <[email protected]>
Description
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/kubernetes-engine/docs/concepts/dws
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review