Skip to content

Conversation

@raushan2016
Copy link
Contributor

@raushan2016 raushan2016 commented Apr 25, 2025

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@apeabody apeabody changed the title Adding sample for flex reservation feat: add sample for flex reservation Apr 25, 2025
@apeabody
Copy link
Contributor

/gcbrun

@apeabody apeabody self-assigned this Apr 25, 2025
@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

Running terraform fmt
gke/standard/zonal/reservation/main.tf
--- old/gke/standard/zonal/reservation/main.tf
+++ new/gke/standard/zonal/reservation/main.tf
@@ -120,8 +120,8 @@
     total_max_node_count = 1
   }
   node_config {
-    machine_type = "e2-medium"
-    flex_start = true
+    machine_type     = "e2-medium"
+    flex_start       = true
     max_run_duration = "604800s"
 
     reservation_affinity {
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>

@raushan2016
Copy link
Contributor Author

/gcbrun

1 similar comment
@apeabody
Copy link
Contributor

/gcbrun

@raushan2016 raushan2016 marked this pull request as ready for review April 25, 2025 23:45
@raushan2016 raushan2016 requested review from a team as code owners April 25, 2025 23:45
@snippet-bot
Copy link

snippet-bot bot commented Apr 25, 2025

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raushan2016!

A few nits / best practices, please also fill out the Intended location, etc, in the PR description.

@msampathkumar
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raushan2016!

@apeabody apeabody merged commit 5a7506e into terraform-google-modules:main Apr 30, 2025
5 checks passed
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
)

* Adding sample for flex reservation

* Fix spacing

* Add provider as google-beta

* formatting

* Moving to separate folder and adding test skip file

* fmt

* Update gke/standard/zonal/dws/main.tf

Co-authored-by: Andrew Peabody <[email protected]>

* fmt

* Validated change

---------

Co-authored-by: Andrew Peabody <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants