Skip to content

Conversation

@pandirigoog
Copy link
Contributor

@pandirigoog pandirigoog commented Apr 30, 2025

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@pandirigoog pandirigoog requested review from a team as code owners April 30, 2025 23:32
@snippet-bot
Copy link

snippet-bot bot commented Apr 30, 2025

Here is the summary of changes.

You are about to add 18 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@pandirigoog pandirigoog changed the title Custom SAN examples docs: Custom SAN examples Apr 30, 2025
Copy link
Contributor

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR has a great start! Need minor changes to improve.

  1. Try to keep region tags unique
  2. Add descriptions or comments to understand why a resources is created. This optional for your but very helpful for me & users to understand your motivation.

Example: description = "Create example sql instance with CA ..."

Copy link
Contributor

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pandirigoog pandirigoog merged commit b37068b into terraform-google-modules:main May 8, 2025
5 checks passed
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
* Custom SAN examples

* docs: Custom SAN examples

* Fix fmt issues

* Add DB engine specific tests

* Use unique tags and add comments

* Make tags unique
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants