-
Notifications
You must be signed in to change notification settings - Fork 286
docs: Custom SAN examples #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud_sql/mysql_instance_custom_subject_alternative_names/main.tf
Outdated
Show resolved
Hide resolved
cloud_sql/mysql_instance_custom_subject_alternative_names/main.tf
Outdated
Show resolved
Hide resolved
cloud_sql/mysql_instance_custom_subject_alternative_names/main.tf
Outdated
Show resolved
Hide resolved
msampathkumar
requested changes
May 5, 2025
Contributor
msampathkumar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR has a great start! Need minor changes to improve.
- Try to keep region tags unique
- Add descriptions or comments to understand why a resources is created. This optional for your but very helpful for me & users to understand your motivation.
Example: description = "Create example sql instance with CA ..."
iennae
reviewed
May 6, 2025
cloud_sql/postgres_instance_custom_subject_alternative_names/main.tf
Outdated
Show resolved
Hide resolved
msampathkumar
approved these changes
May 8, 2025
Contributor
msampathkumar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
hessjcg
approved these changes
May 8, 2025
niharika-98
pushed a commit
to niharika-98/terraform-docs-samples
that referenced
this pull request
Sep 7, 2025
* Custom SAN examples * docs: Custom SAN examples * Fix fmt issues * Add DB engine specific tests * Use unique tags and add comments * Make tags unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review