Skip to content

Conversation

@dishaagarwal03-google
Copy link
Contributor

@dishaagarwal03-google dishaagarwal03-google commented May 14, 2025

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@dishaagarwal03-google dishaagarwal03-google marked this pull request as ready for review May 15, 2025 05:49
@dishaagarwal03-google dishaagarwal03-google requested review from a team as code owners May 15, 2025 05:49
@snippet-bot
Copy link

snippet-bot bot commented May 15, 2025

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dishaagarwal03-google dishaagarwal03-google changed the title Add disks example code for backup-plan and backup-plan-association feat(backupdr) Add disks example code for backup-plan and backup-plan-association May 16, 2025
@glasnt glasnt changed the title feat(backupdr) Add disks example code for backup-plan and backup-plan-association feat(backupdr): Add disks example code for backup-plan and backup-plan-association May 22, 2025
@glasnt
Copy link
Contributor

glasnt commented May 22, 2025

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented May 22, 2025

/gcbrun

@glasnt glasnt added the waiting-response Waiting for issue author to respond. label May 22, 2025
@glasnt
Copy link
Contributor

glasnt commented May 22, 2025

Internal thread on build issues

@glasnt
Copy link
Contributor

glasnt commented May 23, 2025

/gcbrun

1 similar comment
@glasnt
Copy link
Contributor

glasnt commented May 23, 2025

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented May 23, 2025

/gcbrun

@glasnt glasnt enabled auto-merge (squash) May 23, 2025 06:42
@glasnt
Copy link
Contributor

glasnt commented May 23, 2025

We're temporarily disabling these tests to get the samples into the repo. This will be updated next week.

@glasnt glasnt merged commit d71a98b into terraform-google-modules:main May 23, 2025
5 checks passed
@glasnt glasnt mentioned this pull request Jun 4, 2025
1 task
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
…n-association (terraform-google-modules#857)

* Add disks example code for backup-plan and backup-plan-association

* fix(backupdr): change location of disk resource

* fix(backupplanassociation): Remove size from disk

* ensure unique resource names

* ci: disable tests temporarily

---------

Co-authored-by: Katie McLaughlin <[email protected]>
Co-authored-by: Katie McLaughlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-response Waiting for issue author to respond.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants