fix(storage): fix the lifecycle storage sample #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @gurusai-voleti. To help us understand the context of this change, can you please update the PR description to include a reference to a bug with the rationale for the change. This will help us understand the intent of this PR. Thanks in advance! |
Contributor
Author
@glasnt updated the description please check, there is only internal bug on buganizer for this issue |
Contributor
|
/gcbrun |
glasnt
reviewed
Jun 19, 2025
Co-authored-by: Katie McLaughlin <[email protected]>
Contributor
Author
|
/gcbrun |
glasnt
reviewed
Jun 19, 2025
Contributor
|
/gcbrun |
glasnt
approved these changes
Jun 19, 2025
niharika-98
pushed a commit
to niharika-98/terraform-docs-samples
that referenced
this pull request
Sep 7, 2025
…les#865) * fix(storage): fix the lifecycle storage sample * Update storage/object_lifecycle_setting/main.tf Co-authored-by: Katie McLaughlin <[email protected]> * Revert "Update storage/object_lifecycle_setting/main.tf" This reverts commit a1ee4eb. * fix(storage): fix the lifecycle storage sample * lintttt --------- Co-authored-by: Katie McLaughlin <[email protected]> Co-authored-by: Katie McLaughlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in object life cycle example uniform_bucket_level_access is not needed and it might be misleading for the customers, so refined the example to remove the uniform_bucket_level_access flag
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/storage/docs/managing-lifecycles#terraform
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review