-
Notifications
You must be signed in to change notification settings - Fork 286
feat: Add TF samples for creating a Looker (Google Cloud core) Enterprise instance that uses PSC #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
glasnt
merged 11 commits into
terraform-google-modules:main
from
ronnieplooker:bug-429215192
Jul 20, 2025
Merged
feat: Add TF samples for creating a Looker (Google Cloud core) Enterprise instance that uses PSC #871
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5e5c405
feat: Prepared looker-core-psc for inclusion in C.G.C. documentation
ronnieplooker e77771f
Merge branch 'main' into bug-429215192
glasnt 809722e
Update correct copyright year
ronnieplooker fdadfbc
Use "default" rather than "main"
ronnieplooker 2eff45e
reviewer updates
ronnieplooker 71ca799
add test.yaml file to skip tests
ronnieplooker c50a784
update metadata
glasnt 66bdeb9
clarify allowed vpc and service attachment arguments
ronnieplooker 5c2320e
Merge branch 'main' into bug-429215192
glasnt abf30c4
lint
glasnt 26ae713
lint
glasnt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /** | ||
| * Copyright 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| # [START looker_google_looker_instance_psc] | ||
| # Create an ENTERPRISE edition Looker (Google Cloud core) instance that has PSC enabled. | ||
| resource "google_looker_instance" "default" { | ||
| name = "my-instance" | ||
| platform_edition = "LOOKER_CORE_ENTERPRISE_ANNUAL" | ||
| region = "us-central1" | ||
| private_ip_enabled = false | ||
| public_ip_enabled = false | ||
| psc_enabled = true | ||
| oauth_config { | ||
| client_id = "my-client-id" | ||
| client_secret = "my-client-secret" | ||
| } | ||
| psc_config { | ||
| # allowed_vpcs = ["projects/{project}/global/networks/{network}"] | ||
| # (Optional) List of VPCs that are allowed ingress into the Looker instance. Set an allowed VPC if you are creating an instance that uses only private IP. | ||
| } | ||
glasnt marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| # [END looker_google_looker_instance_psc] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| apiVersion: blueprints.cloud.google.com/v1alpha1 | ||
| kind: BlueprintTest | ||
| metadata: | ||
| name: looker_core_psc | ||
| spec: | ||
| skip: true |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.