Skip to content

Conversation

@seviet
Copy link
Contributor

@seviet seviet commented Aug 8, 2025

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • [ X ] Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

  • [ X ] I have performed tests described in the Contributing guide:

    • [ X ] Tests pass: terraform apply
    • [ X ] Lint pass: terraform fmt check

Intended location

  • [ X ] Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

https://cloud.google.com/sql/docs/sqlserver/replication/create-replica#cascadable-replica-steps-sqlserver
https://cloud.google.com/sql/docs/sqlserver/use-advanced-disaster-recovery

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@seviet seviet requested review from a team as code owners August 8, 2025 18:08
@snippet-bot
Copy link

snippet-bot bot commented Aug 8, 2025

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@glasnt
Copy link
Contributor

glasnt commented Aug 14, 2025

/gcbrun

@seviet
Copy link
Contributor Author

seviet commented Aug 14, 2025

/gcbrun

Can you run again? Sorry I must have run before adding the test.yaml

Copy link
Contributor

@glasnt glasnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match the other database version switchover samples, this PR looks okay. You might find when you integrate these samples into the docs you might want to make some changes to the code, to nicely present the mulitple edits required in the resources during the switchover. We can address those when needed.

The only change I've suggested here is around CI workarounds that are not needed since these samples skip apply validation.

@glasnt
Copy link
Contributor

glasnt commented Aug 14, 2025

/gcbrun

@glasnt glasnt merged commit 55db0f9 into terraform-google-modules:main Aug 14, 2025
5 checks passed
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
…erraform-google-modules#884)

* feat(cloud_sql): Add samples for SQL Server Advanced DR switchover

* Fix region tags

* Fix whitespace issues

* remove unneeded workarounds

---------

Co-authored-by: Katie McLaughlin <[email protected]>
Co-authored-by: Katie McLaughlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants