-
Notifications
You must be signed in to change notification settings - Fork 286
feat(cloud_sql): Add samples for SQL Server Advanced DR switchover #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
|
/gcbrun |
Can you run again? Sorry I must have run before adding the test.yaml |
glasnt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match the other database version switchover samples, this PR looks okay. You might find when you integrate these samples into the docs you might want to make some changes to the code, to nicely present the mulitple edits required in the resources during the switchover. We can address those when needed.
The only change I've suggested here is around CI workarounds that are not needed since these samples skip apply validation.
cloud_sql/sqlserver_instance_switchover/create_dr_replica/main.tf
Outdated
Show resolved
Hide resolved
cloud_sql/sqlserver_instance_switchover/create_dr_replica/main.tf
Outdated
Show resolved
Hide resolved
cloud_sql/sqlserver_instance_switchover/switchover_begin/main.tf
Outdated
Show resolved
Hide resolved
cloud_sql/sqlserver_instance_switchover/switchover_begin/main.tf
Outdated
Show resolved
Hide resolved
cloud_sql/sqlserver_instance_switchover/switchover_finish/main.tf
Outdated
Show resolved
Hide resolved
cloud_sql/sqlserver_instance_switchover/switchover_finish/main.tf
Outdated
Show resolved
Hide resolved
|
/gcbrun |
…erraform-google-modules#884) * feat(cloud_sql): Add samples for SQL Server Advanced DR switchover * Fix region tags * Fix whitespace issues * remove unneeded workarounds --------- Co-authored-by: Katie McLaughlin <[email protected]> Co-authored-by: Katie McLaughlin <[email protected]>
Description
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
[ X ] I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Location(s):
https://cloud.google.com/sql/docs/sqlserver/replication/create-replica#cascadable-replica-steps-sqlserver
https://cloud.google.com/sql/docs/sqlserver/use-advanced-disaster-recovery
Reason:
API enablement
Review