feat(cloud_sql): add MySQL and PG samples for Read Pool #886
+159
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `test.yaml` file for the `mysql_instance_replica_pool/main.tf` file.
Create `mysql_instance_replica_pool` folder. Add a MySQL `main.tf` file with Terraform samples related to the read pool feature. Operations include the following: * Create a read pool * Convert a read replica to a read pool * Convert a read pool to a read replica * Update read pool node count * Edit read pool configuration Add a corresponding `test.yaml` file.
Create `postgres_instance_read_pool` folder. Add a PostgreSQL `main.tf` file with Terraform samples related to the read pool feature. Operations include the following: * Create a read pool * Convert a read replica to a read pool * Convert a read pool to a read replica * Update read pool node count * Edit read pool configuration Add a corresponding `test.yaml` file.
psung
changed the title
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
This was referenced Aug 14, 2025
Closed
Closed
Closed
11 tasks
Contributor
|
/gcbrun |
glasnt
reviewed
Aug 14, 2025
Contributor
glasnt
left a comment
glasnt
left a comment
There was a problem hiding this comment.
Most things here look okay, apart from some cleanup.
Given this sample is not terraform apply'd as part of testing, can you please confirm the Read Pool functionality works with the latest versions of MySQL and PostgreSQL provided by Cloud SQL, then I can apply those changes and merge this PR.
Contributor
Author
|
Yes, Read Pool is supported on MySQL 8.4 as well as PG 17. The other suggested changes look fine to me too. |
glasnt
approved these changes
Aug 14, 2025
Contributor
|
/gcbrun |
niharika-98
pushed a commit
to niharika-98/terraform-docs-samples
that referenced
this pull request
Sep 7, 2025
…ogle-modules#886) * Create test.yaml Add a `test.yaml` file for the `mysql_instance_replica_pool/main.tf` file. * Create main.tf Create `mysql_instance_replica_pool` folder. Add a MySQL `main.tf` file with Terraform samples related to the read pool feature. Operations include the following: * Create a read pool * Convert a read replica to a read pool * Convert a read pool to a read replica * Update read pool node count * Edit read pool configuration Add a corresponding `test.yaml` file. * Create test.yaml * Create main.tf * Delete cloud_sql/mysql_instance_replica_pool/test.yaml * Delete mysql_instance_replica_pool/main.tf * Create main.tf Create `postgres_instance_read_pool` folder. Add a PostgreSQL `main.tf` file with Terraform samples related to the read pool feature. Operations include the following: * Create a read pool * Convert a read replica to a read pool * Convert a read pool to a read replica * Update read pool node count * Edit read pool configuration Add a corresponding `test.yaml` file. * Create test.yaml * Retain only the creation sample * Move samples to cloud_sql subdir * Remove 'create' from names as it's implied * terraform fmt * remove CI aroundarounds, update metadata name * Update database versions to latest --------- Co-authored-by: Rebecca Peterson <[email protected]> Co-authored-by: Katie McLaughlin <[email protected]> Co-authored-by: Katie McLaughlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/sql/docs/mysql/create-read-pool, https://cloud.google.com/sql/docs/postgres/create-read-pool
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review