Skip to content

Conversation

@kushallunkad-google
Copy link

@kushallunkad-google kushallunkad-google commented Nov 6, 2025

Description

Fixes #<b/454546432>

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@kushallunkad-google kushallunkad-google marked this pull request as ready for review November 6, 2025 10:29
@kushallunkad-google kushallunkad-google requested review from a team as code owners November 6, 2025 10:29
@snippet-bot
Copy link

snippet-bot bot commented Nov 6, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

backup_plan_id = "my-bp"
resource_type = "compute.googleapis.com/Instance"
backup_vault = google_backup_dr_backup_vault.default.name
# log_retention_days = 2 # Only applicable for Cloud SQL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be created in a separate PR. It's unrelated to this feature

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually both the changes were part of the same bug that is why created a single pull request.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry but we would need to hold this PR for a few days as there is some issue which is being resolved , thanks!

@glasnt
Copy link
Contributor

glasnt commented Nov 6, 2025

The tests are failing with deletion step blocking:

Error waiting for Deleting BackupPlanAssociation: Error code 9, message: There is already a pending blocking operation for instance: ci-tf-samples-1-lszrmlcq:instance-test

I'm not sure if this is an issue with the provider, or something else that's affecting resource cleanup.

@glasnt glasnt changed the title introducing associations attached with csql instances feat(backupdr): introducing associations attached with csql instances Nov 6, 2025
@kushallunkad-google
Copy link
Author

The tests are failing with deletion step blocking:

Error waiting for Deleting BackupPlanAssociation: Error code 9, message: There is already a pending blocking operation for instance: ci-tf-samples-1-lszrmlcq:instance-test

I'm not sure if this is an issue with the provider, or something else that's affecting resource cleanup.

This is a timing issue in the test workflow, not a defect in the service API or the Terraform provider. The resource cleanup is happening too quickly, before the service has completed its mandatory initial operation(As soon as backup plan association is created it triggers a backup -> which is a pending operation).
This should not be a problem in production environments, as resources typically exist long enough for initial operations to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants