fix!: Network dns refactory #1365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renato-rudnicki
requested review from
a team,
eeaton,
rjerrems and
sleighton2022
as code owners
daniel-cit
reviewed
Feb 17, 2025
daniel-cit
reviewed
Feb 17, 2025
| restricted_subnet_primary_ranges = local.restricted_subnet_primary_ranges | ||
| restricted_subnet_secondary_ranges = local.restricted_subnet_secondary_ranges | ||
| restricted_private_service_connect_ip = "10.17.0.8" | ||
| restricted_private_service_connect_ip = "10.17.0.7" |
daniel-cit
reviewed
Feb 17, 2025
daniel-cit
reviewed
Feb 17, 2025
daniel-cit
reviewed
Feb 17, 2025
daniel-cit
reviewed
Feb 17, 2025
eeaton
reviewed
Mar 12, 2025
eeaton
reviewed
Mar 12, 2025
eeaton
reviewed
Mar 12, 2025
Collaborator
eeaton
left a comment
eeaton
left a comment
There was a problem hiding this comment.
I think this all looks correct, but before I approve can you help me doublecheck my understanding on the following comments?
eeaton
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement a DNS hub for single forwarding between multiple hubs, enabling DNS communication between on-prem and a single GCP hub.