refactor!: Remove base project #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* first commit * removing base_shared service projects * fix example storage cmek * fixes * changing network step name and references to 3-networks-svpc * replacing shared resources and references names to svpc * fix lint * fix 2-environments step * fix network steps * fix network svps step * fix 4-projects step * remove some base references * delete base shared vpc resources * rm base shared project in integration tests * rm network hub and spoke base project resources * fix hub and spoke README * fix READMEs * fix README * gitignore * fix tfvars * fix conflicts * fixes steps: 2, 4 and 5 * rm restricted ref * rm restricted ref * fix networks-svpc README * bootstrap README fixes * fix 1-org step * fix environments step * fix networks hub and spoke step * add vpc label to svpc prjs * fix hub and spoke step * fix netowrks intgration test * fix projects step * fixes svpc networks step * fixes base_env and single_project modules * fixes app infra step and networks svpc README * rm restricted refs in root README * general fixes * change dual shared ref to shared vpc * review fixes * review corrections * fix interconnect example file name * fix symbolic link variables * review corrections * fix integration network tests * fix root README * remove unnecessary extra map of srings * add kms project number outputs * add depends on in cmek storage * fix lint * fix enforce_vpcsc in shared vpc module * add kms prk number output and sa roles to app infra service account * move CMEK KMS example to floating project * add instruction to the user add a infra pipeline service account in the perimeter * change project * fix conflicts * fix conflicts * fix base_env module conflicts * fix conflicts * fix base_env module README * fix conflicts * fix output and shared_test * fix symbolic link for production.auto.tfvars * update name for dns_project_id * add missing line * update README * update vpc name for DNS * add ouptut and fix README * fix outputs for network and firewall polices * fix remote.tf * fix remote.tf * remove google provider version 6.26.0 due a bug * removing google-provider v6.26.0 * fix integration tests for hub-and-spoke * fix data name --------- Co-authored-by: Daniel Andrade <[email protected]> Co-authored-by: Renato Rudnicki <[email protected]>
renato-rudnicki
requested review from
a team,
eeaton,
rjerrems and
sleighton2022
as code owners
renato-rudnicki
changed the title
daniel-cit
reviewed
Mar 26, 2025
eeaton
approved these changes
Mar 28, 2025
Collaborator
eeaton
left a comment
eeaton
left a comment
There was a problem hiding this comment.
A few minor comments but overall LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following refactoring: