Skip to content

fix!: use SCC v2 resources #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2025
Merged

fix!: use SCC v2 resources #1432

merged 2 commits into from
Sep 11, 2025

Conversation

@daniel-cit
Copy link
Contributor

@daniel-cit daniel-cit commented Sep 10, 2025

fixes #1189

obriensystems
obriensystems approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@obriensystems obriensystems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-cit daniel-cit marked this pull request as ready for review September 11, 2025 18:04
@daniel-cit daniel-cit changed the title fix: use SCC v2 resources fix!: use SCC v2 resources Sep 11, 2025
@daniel-cit
Copy link
Contributor Author

daniel-cit commented Sep 11, 2025

@apeabody Could you PTAL

apeabody
apeabody approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit!

@apeabody apeabody merged commit a4ea938 into terraform-google-modules:main Sep 11, 2025
7 checks passed
@release-please release-please bot mentioned this pull request Aug 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeabody apeabody apeabody approved these changes

@eeaton eeaton Awaiting requested review from eeaton eeaton is a code owner

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

@sleighton2022 sleighton2022 Awaiting requested review from sleighton2022 sleighton2022 is a code owner

+1 more reviewer

@obriensystems obriensystems obriensystems approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1-org: Apply fails for scc resources with API version error.

3 participants

@daniel-cit @apeabody @obriensystems