Skip to content

fix(cai-monitoring): update module.cloud_function's function_location input to location#1458

Open
kevcube wants to merge 1 commit intoterraform-google-modules:mainfrom
kevcube:patch-1
Open

fix(cai-monitoring): update module.cloud_function's function_location input to location#1458
kevcube wants to merge 1 commit intoterraform-google-modules:mainfrom
kevcube:patch-1

Conversation

@kevcube
Copy link

@kevcube kevcube commented Feb 12, 2026

The upstream module has made a breaking change to deprecate function_location to location, breaking this cai-monitoring module.

ref: https://github.com/GoogleCloudPlatform/terraform-google-cloud-functions/pull/194/changes

@google-cla
Copy link

google-cla bot commented Feb 12, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link

Summary of Changes

Hello @kevcube, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a breaking change introduced in an upstream Terraform module for Google Cloud Functions. It updates the module to a newer version and adjusts the input variable name for function location, ensuring continued compatibility and functionality of the cai-monitoring module.

Highlights

  • Module Version Update: Updated the GoogleCloudPlatform/cloud-functions/google module from version ~> 0.6 to ~> 0.8 to incorporate upstream changes.
  • Input Variable Renaming: Renamed the function_location input variable to location within the cloud_function module, aligning with a breaking change in the upstream module.
Changelog
  • 1-org/modules/cai-monitoring/main.tf
    • Updated the cloud_function module version from ~> 0.6 to ~> 0.8.
    • Changed the function_location argument to location for the cloud_function module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a breaking change in the upstream GoogleCloudPlatform/cloud-functions/google module by updating its version and renaming the function_location input to location. The change is straightforward and necessary. I have one suggestion to pin the module to a specific version to ensure more predictable and stable deployments.

module "cloud_function" {
source = "GoogleCloudPlatform/cloud-functions/google"
version = "~> 0.6"
version = "~> 0.8"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better reproducibility and to avoid unexpected changes from upstream module updates, it's a good practice to pin the module version to a specific version instead of using a pessimistic version constraint. This ensures that your infrastructure doesn't change unexpectedly when a new minor version of the module is released.

  version = "0.8.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant