Skip to content

Conversation

@ayushmjain
Copy link
Collaborator

@ayushmjain ayushmjain commented Feb 26, 2025

Add env_vars output variable. This can be used for connecting to cloud run, MIG instance template. This is similar to how cloud sql is connected to cloud run / MIG instance template, example

Remove IAM roles that aren't required to deploy this module:
roles/cloudkms.cryptoKeyEncrypterDecrypter
roles/owner

@ayushmjain ayushmjain requested review from a team and davenportjw as code owners February 26, 2025 06:27
@q2w
Copy link
Collaborator

q2w commented Feb 27, 2025

lint check is failing. Please run the terraform fmt in the root module.

@q2w
Copy link
Collaborator

q2w commented Feb 27, 2025

/gcbrun

@ayushmjain
Copy link
Collaborator Author

lint check is failing. Please run the terraform fmt in the root module.

Done

@ayushmjain ayushmjain closed this Feb 27, 2025
@ayushmjain ayushmjain reopened this Feb 27, 2025
@q2w
Copy link
Collaborator

q2w commented Feb 27, 2025

/gcbrun

@q2w
Copy link
Collaborator

q2w commented Feb 27, 2025

/gcbrun

@bharathkkb
Copy link
Member

/gcbrun

@bharathkkb bharathkkb enabled auto-merge (squash) February 28, 2025 05:31
@q2w
Copy link
Collaborator

q2w commented Feb 28, 2025

/gcbrun

@bharathkkb bharathkkb disabled auto-merge February 28, 2025 16:09
@bharathkkb bharathkkb merged commit ab9ed8c into terraform-google-modules:main Feb 28, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants