Skip to content

fix: update display metadata to fix regex for bigquery dataset id #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 19, 2025
Merged

fix: update display metadata to fix regex for bigquery dataset id #392

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3f708c4
Adding data field in schema for defaults
amrkk123 May 2, 2025
f39b57b
Merge branch 'terraform-google-modules:main' into main
amrkk123 May 6, 2025
c72228c
Fix regex for bigquery dataset id
amrkk123 May 6, 2025
7bc5ec4
Update upper limit for dataset regex
amrkk123 May 7, 2025
6349cb4
Fixing regex and changing defaults for tables
amrkk123 May 14, 2025
77a1ddc
Updating description for table schema
amrkk123 May 15, 2025
c3145f3
Update metadata.display.yaml
q2w May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions metadata.display.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
dataset_id:
name: dataset_id
title: Dataset Id
regexValidation: ^[a-zA-Z0-9_]{1,1024}$$
regexValidation: ^[a-zA-Z0-9_]{1,1000}[a-zA-Z0-9_]{0,24}$
validation: Must contain only letters, numbers, or underscores. Must be 1024 characters or fewer.
dataset_labels:
name: dataset_labels
Expand Down Expand Up @@ -90,7 +90,7 @@ spec:
altDefaults:
- type: ALTERNATE_TYPE_DC
value:
- schema: "[{\"description\": \"Full visitor ID\",\"mode\": \"NULLABLE\",\"name\": \"fullVisitorId\",\"type\": \"STRING\"},{\"description\": \"Visit number\",\"mode\": \"NULLABLE\",\"name\": \"visitNumber\",\"type\": \"INTEGER\"},{\"description\": \"Data\",\"mode\": \"NULLABLE\",\"name\": \"data\",\"type\": \"STRING\"}]"
- schema: "[{\"description\": \"An example string field. Illustrates the storage of textual data compliant with STRING type\",\"mode\": \"NULLABLE\",\"name\": \"exampleID\",\"type\": \"STRING\"},{\"description\": \"An integer value. Demonstrates the representation of whole number data compliant with INTEGER type\",\"mode\": \"NULLABLE\",\"name\": \"numberField\",\"type\": \"INTEGER\"},{\"description\": \"This field stores data crucial for Google Cloud Pub/Sub connectivity\",\"mode\": \"NULLABLE\",\"name\": \"data\",\"type\": \"STRING\"}]"
table_id: table-1
views:
name: views
Expand Down