Skip to content

Conversation

@aming27
Copy link

@aming27 aming27 commented Jun 11, 2025

@aming27 aming27 requested review from a team and imrannayer as code owners June 11, 2025 09:39
@google-cla
Copy link

google-cla bot commented Jun 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Devansh-Bhatt
Copy link

Devansh-Bhatt commented Jul 31, 2025

@aming27 I think we should keep the the value of records variable present in the routing policy dynamic block to be optional as well. This way it would let me keep only health-checked targets without any normal rrdatas. Currently It does not let me do that. Otherwise, this patch works perfectly

@aming27
Copy link
Author

aming27 commented Jul 31, 2025

@Devansh-Bhatt I've added rrdatas = try(wrr.value.records, []) for making rrdatas optional.

@aming27 aming27 changed the title Add support to health check feat: Add support to health check Jul 31, 2025
@aming27
Copy link
Author

aming27 commented Sep 1, 2025

Hi @Devansh-Bhatt please any update ? Thanks!!!

@JorTurFer
Copy link

Hi!
Any update?

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Dec 6, 2025
@JorTurFer
Copy link

not stale @imrannayer

@github-actions github-actions bot removed the Stale label Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants