-
Notifications
You must be signed in to change notification settings - Fork 86
feat: Add support to health check #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@aming27 I think we should keep the the value of records variable present in the routing policy dynamic block to be optional as well. This way it would let me keep only health-checked targets without any normal rrdatas. Currently It does not let me do that. Otherwise, this patch works perfectly |
|
@Devansh-Bhatt I've added rrdatas = try(wrr.value.records, []) for making rrdatas optional. |
|
Hi @Devansh-Bhatt please any update ? Thanks!!! |
|
Hi! |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
not stale @imrannayer |
Add health_checked_targets support into wrr block.(https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/dns_record_set.html#health_checked_targets-1)