-
Notifications
You must be signed in to change notification settings - Fork 58
feat: partner interconnect #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: partner interconnect #147
Conversation
Signed-off-by: Ricky Hariady <[email protected]>
8f61b06 to
89f7eaf
Compare
Signed-off-by: Ricky Hariady <[email protected]>
|
@rhariady thx for the PR. |
Thanks @imrannayer! And I think I have followed up all your comment. BTW, I also add |
|
@rhariady lint test failed |
@imrannayer Ahh, yes. I was using latest version of terraform-docs. Fixed BTW. |
|
@rhariady can u plz resolve the conflicts |
|
|
/gcbrun |
Currently when we create interconnect attachment with PARTNER type, GCP will automatically create a router interface and peers for us (with
management_typeattribute set toMANAGED_BY_ATTACHMENT). Because of this, usinginterconnect_attachmentmodule from this repo to provision a PARTNER type interconnect will fail because it will try to create another interface and peer, while GCP only allow 1 interface per attachment and IP type (see issue #7)This PR will allow interface (and peer) creation to be optional by introducing new value named
create_interface. When the value isfalse, it won't create the interface and peers resource. User can later import this resources from the one automatically generated by GCP.This PR also add
edge_availability_domainargument and set default value for several variable so it will work right away with PARTNER interconnect type.Fix #7