-
Notifications
You must be signed in to change notification settings - Fork 58
feat!: MD5 authentication for BGP support #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: MD5 authentication for BGP support #149
Conversation
Signed-off-by: Ricky Hariady <[email protected]>
|
@rhariady thanks foe the PR. Left some comments. |
|
Hi, thanks for the review @imrannayer! Regarding But then, i realize that since all these variables had already been |
c21abf4 to
48a86f9
Compare
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
@rhariady I merged this PR. Can you plz submit another PR to change min provider version in versions.tf file for interface sub-module to 5.12? MD5 authentication was part of that version. |
Thanks @imrannayer! And sorry i missed to update the min provider version, but i have open another MR for that as you suggested in #153. |
This PR add support for MD5 authentication in BGP session in the interface submodule (include reference in interconnect_attachment module). Needs min provider version 5.12
BEGIN_COMMIT_OVERRIDE
feat!: MD5 authentication for BGP support
END_COMMIT_OVERRIDE