feat: Add Composer v3 sub-module #155
Conversation
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
| locals { | ||
| network_project_id = var.network_project_id != "" ? var.network_project_id : var.project_id | ||
| subnetwork_region = var.subnetwork_region != "" ? var.subnetwork_region : var.region | ||
| cloud_composer_sa = format("service-%[email protected]", data.google_project.project.number) |
There was a problem hiding this comment.
@prabhu34 can u try project_service_identity to get service account name. This resource support a few service.
There was a problem hiding this comment.
Yes, I'm aware of this. We can infact update it in here as well test/setup/iam.tf and use that output directly.
There was a problem hiding this comment.
I would add on to it. Enabling service identities are already part of project-factory module in the setup/. Lets not complicate this as Composer identity is being created when API is enabled.
From a customer perspective as well, they can enable identities and then invoke Composer modules.
Skipping this for now.
Feel free to add your thoughts!
| } | ||
|
|
||
| dynamic "software_config" { | ||
| for_each = [ |
There was a problem hiding this comment.
@prabhu34 can this handle software_config = null
There was a problem hiding this comment.
software_config is never null in this implementation as it is not a single map or object.
image_version and web_server_plugins_mode are having default values, so this will never be null.
Let me know your thoughts!
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
@imrannayer Somehow the fixtures are being demanded for v3. Any reason why? |
|
@prabhu34 check variables in your example. They should be all hard coded except the ones which are coming from output of test/setup execution. |
imrannayer
changed the title
3 participants
Added a submodule to support Composer v3 version, a managed service of Apache Airflow.
Composer v3 simplifies networking for the environment. This module creates a network attachment by only setting
create_network_attachmenttotrue.Also use existing network attachment by setting
create_network_attachmenttofalseandcomposer_network_attachment_namewith the name of the attachment.Refer to Composer v3 networking changes in the documentation.
This will resolve #152.