-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat!: Change the default value of "monitoring_enable_managed_prometheus" var to null #2188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Change the default value of "monitoring_enable_managed_prometheus" var to null #2188
Conversation
|
/gcbrun |
|
Hi @legal90! From the CI test: |
|
@apeabody Thank you! I will take a look at it soon. |
This reverts commit 2991d95.
… null That will allow to properly identify whether that var is set (overridden by a caller) or not. That's important for the value of `local.logmon_config_is_set`, which is then used in dynamic block conditions.
|
@apeabody I rolled back my previous changes and implemented the fix using a different approach - by changing the default value of Could you please re-trigger the integration test? |
|
/gcbrun |
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @legal90!
|
/gcbrun |
Fixes #1706
This PR is a continuation of #1715 by removing the condition formonitoring_configand turning it into a "static" block.This PR is a continuation of #2155.
Here we change the default value of the variable
monitoring_enable_managed_prometheustonull.That is supposed to fix the calculation of
local.logmon_config_is_set. Now it will returntruenot only whenmonitoring_enable_managed_prometheusis set totrue, but also when it is set tofalse.