Skip to content

Conversation

@apeabody
Copy link
Collaborator

@apeabody apeabody commented Nov 20, 2024

We should use the private_endpoint when enable_private_endpoint is true, even if deploy_using_private_endpoint is not.

Needed for TPG v6.11+

@apeabody apeabody marked this pull request as ready for review November 21, 2024 16:12
@apeabody apeabody requested review from a team, ericyz and gtsorbo as code owners November 21, 2024 16:12
@apeabody apeabody changed the title fix(private-cluster): use private endpoint fix(private-cluster)!: use private endpoint Nov 21, 2024
@apeabody apeabody force-pushed the ap/private_endpoint branch 3 times, most recently from 3f90c83 to e4ddf7f Compare November 22, 2024 22:07
@apeabody apeabody force-pushed the ap/private_endpoint branch from e4ddf7f to 387002b Compare November 22, 2024 22:08
@apeabody apeabody enabled auto-merge (squash) November 22, 2024 23:19
@apeabody apeabody merged commit 4b155cd into master Nov 23, 2024
8 checks passed
@apeabody apeabody deleted the ap/private_endpoint branch November 23, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants