Skip to content

chore: consolidate test utils #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2024
Merged

chore: consolidate test utils #2191

merged 4 commits into from
Nov 25, 2024

Conversation

@apeabody
Copy link
Collaborator

@apeabody apeabody commented Nov 22, 2024 •
edited
Loading

  • switch to new bpt.utils ParseKubectlJSONResult()
  • consolidate local utils > testutils (also avoids namespce collusion with bpt.utils)

@apeabody apeabody marked this pull request as ready for review November 22, 2024 21:51
@apeabody apeabody requested review from a team, ericyz and gtsorbo as code owners November 22, 2024 21:51
@apeabody apeabody enabled auto-merge (squash) November 22, 2024 23:20
@apeabody apeabody merged commit 82edcfc into master Nov 25, 2024
8 checks passed
@apeabody apeabody deleted the ap/consolidate branch November 25, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@g-awmalik g-awmalik g-awmalik approved these changes

@ericyz ericyz Awaiting requested review from ericyz

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apeabody @g-awmalik