fix: min_cpu_platform ref in cluster autoscaling #2208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/gcbrun |
apeabody
reviewed
Dec 10, 2024
Collaborator
apeabody
left a comment
apeabody
left a comment
There was a problem hiding this comment.
Thanks @DrFaust92 - Could we had a test to confirm this is now working as expected and prevent regression?
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
DrFaust92
force-pushed
the
fix-min-cpu-plat
branch
from
02f38dd to
e3a40d9
Compare
Collaborator
|
/gcbrun |
apeabody
approved these changes
Dec 17, 2024
Collaborator
apeabody
left a comment
apeabody
left a comment
There was a problem hiding this comment.
Thanks for the contribution @DrFaust92!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.