-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add support for custom monitoring metrics writer role #2239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
apeabody
merged 8 commits into
terraform-google-modules:main
from
samuelarogbonlo:feature/add-custom-metrics-writer-role
Jan 17, 2025
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2d3660c
feat: add support for custom monitoring metrics writer role
samuelarogbonlo 0c8e4df
Merge branch 'terraform-google-modules:main' into feature/add-custom-…
samuelarogbonlo 6d8c36d
Merge branch 'main' into feature/add-custom-metrics-writer-role
samuelarogbonlo c591bb3
style: fix terraform formatting
samuelarogbonlo 7916c38
chore: remove test files and cleanup unintended changes
samuelarogbonlo df4ca10
feat: add custom metrics writer role to autogen templates
samuelarogbonlo bf60dc9
chore: regenerate modules from templates
samuelarogbonlo f9919c6
Merge branch 'main' into feature/add-custom-metrics-writer-role
apeabody File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule terraform-google-kubernetes-engine
added at
70a28a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| module "gke" { | ||
| source = "../modules/beta-private-cluster" | ||
| project_id = "rare-style-447407-s1" | ||
| name = "test-custom-role" | ||
| region = "us-central1" | ||
| network = "default" | ||
| subnetwork = "default" | ||
| ip_range_pods = "gke-pods" | ||
| ip_range_services = "gke-services" | ||
| monitoring_metric_writer_role = "projects/rare-style-447407-s1/roles/custom_metrics_writer" | ||
| } |
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.