Skip to content

fix: node pool creation should depend on necessary firewall rules #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: node pool creation should depend on necessary firewall rules #2245

merged 1 commit into from
Jan 15, 2025

Conversation

@wjf3121
Copy link
Contributor

@wjf3121 wjf3121 commented Jan 15, 2025

fix #2243

@wjf3121 wjf3121 requested review from a team, apeabody and ericyz as code owners January 15, 2025 16:15
@google-cla
Copy link

google-cla bot commented Jan 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@wjf3121 wjf3121 mentioned this pull request Jan 15, 2025
Closed
@apeabody
Copy link
Collaborator

apeabody commented Jan 15, 2025

/gcbrun

@apeabody apeabody self-assigned this Jan 15, 2025
apeabody
apeabody approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @wjf3121!

@apeabody apeabody merged commit 8098489 into terraform-google-modules:main Jan 15, 2025
4 checks passed
@release-please release-please bot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeabody apeabody apeabody approved these changes

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

Assignees

@apeabody apeabody

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

google_container_node_pool.pools should depend on google_compute_firewall.intra_egress

2 participants

@wjf3121 @apeabody