Skip to content

Conversation

@DrFaust92
Copy link
Contributor

No description provided.

@DrFaust92 DrFaust92 requested review from a team, apeabody and ericyz as code owners July 15, 2025 22:08
@DrFaust92 DrFaust92 changed the title feat: add support for flex start feat(TPG>=6.39)!: add support for flex start Jul 15, 2025
@DrFaust92 DrFaust92 closed this Jul 15, 2025
@DrFaust92 DrFaust92 reopened this Jul 15, 2025
@apeabody
Copy link
Collaborator

/gcbrun

1 similar comment
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody added blocked Blocked by some other work and removed blocked Blocked by some other work labels Jul 18, 2025
@apeabody
Copy link
Collaborator

/gcbrun

2 similar comments
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@DrFaust92
Copy link
Contributor Author

apeabody can you share error logs? i cant see an issue locally

@apeabody
Copy link
Collaborator

apeabody can you share error logs? i cant see an issue locally

Likely not related to your change NodePool pool-03 was created in the error state "ERROR", re-running the tests.

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

Hi @DrFaust92 - This will unfortunately need a manual rebase.

@DrFaust92
Copy link
Contributor Author

apeabody no worries, done!

@apeabody
Copy link
Collaborator

apeabody commented Aug 5, 2025

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Aug 7, 2025

/gcbrun

@apeabody apeabody changed the title feat(TPG>=6.39)!: add support for flex start feat: add support for flex start Aug 7, 2025
@apeabody apeabody changed the title feat: add support for flex start feat!: add support for flex start Aug 7, 2025
@apeabody
Copy link
Collaborator

apeabody commented Aug 7, 2025

Keeping as breaking change for addition of flex_start to force_node_pool_recreation_resources

@apeabody apeabody added the blocked Blocked by some other work label Aug 7, 2025
@apeabody apeabody removed the blocked Blocked by some other work label Aug 8, 2025
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

@apeabody apeabody merged commit c0c80e6 into terraform-google-modules:main Aug 8, 2025
4 checks passed
@apeabody apeabody self-assigned this Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants