feat: Simple GKE modules for ADC #2397

daniel-cit · 2025-08-04T22:30:05Z

This PR creates simple wrapper modules for ADC

… of golden file in private_zonal_with_networking_test

daniel-cit · 2025-08-05T14:32:32Z

/gcbrun

apeabody

Thanks @daniel-cit!

examples/gke_autopilot_cluster/README.md

examples/gke_standard_cluster/README.md

examples/gke_standard_cluster/versions.tf

examples/gke_autopilot_cluster/versions.tf

daniel-cit · 2025-08-05T16:43:41Z

Hi @apeabody
how can I fix this error?

Step #37 - "verify upstream-nameservers-local":         	Error:      	Not equal: 
Step #37 - "verify upstream-nameservers-local":         	            	expected: "RUNNING"
Step #37 - "verify upstream-nameservers-local":         	            	actual  : "RECONCILING"
Step #37 - "verify upstream-nameservers-local":         	            	
Step #37 - "verify upstream-nameservers-local":         	            	Diff:
Step #37 - "verify upstream-nameservers-local":         	            	--- Expected
Step #37 - "verify upstream-nameservers-local":         	            	+++ Actual
Step #37 - "verify upstream-nameservers-local":         	            	@@ -1 +1 @@
Step #37 - "verify upstream-nameservers-local":         	            	-RUNNING
Step #37 - "verify upstream-nameservers-local":         	            	+RECONCILING
Step #37 - "verify upstream-nameservers-local":         	Test:       	TestUpstreamNameservers
Step #37 - "verify upstream-nameservers-local":         	Messages:   	For path "status" expected "RECONCILING" to match fixture "RUNNING"

should I remove the status from the golden file and test the status like this?

assert.Contains([]string{"RUNNING", "RECONCILING"}, op.Get("status").String())

apeabody · 2025-08-05T16:55:27Z

Hi @apeabody how can I fix this error?

Step #37 - "verify upstream-nameservers-local":         	Error:      	Not equal: 
Step #37 - "verify upstream-nameservers-local":         	            	expected: "RUNNING"
Step #37 - "verify upstream-nameservers-local":         	            	actual  : "RECONCILING"
Step #37 - "verify upstream-nameservers-local":         	            	
Step #37 - "verify upstream-nameservers-local":         	            	Diff:
Step #37 - "verify upstream-nameservers-local":         	            	--- Expected
Step #37 - "verify upstream-nameservers-local":         	            	+++ Actual
Step #37 - "verify upstream-nameservers-local":         	            	@@ -1 +1 @@
Step #37 - "verify upstream-nameservers-local":         	            	-RUNNING
Step #37 - "verify upstream-nameservers-local":         	            	+RECONCILING
Step #37 - "verify upstream-nameservers-local":         	Test:       	TestUpstreamNameservers
Step #37 - "verify upstream-nameservers-local":         	Messages:   	For path "status" expected "RECONCILING" to match fixture "RUNNING"

should I remove the status from the golden file and test the status like this?

assert.Contains([]string{"RUNNING", "RECONCILING"}, op.Get("status").String())

Hi @daniel-cit - Yes, this is becoming an increasing common, so let's do that. Thanks!

…eservers example

apeabody · 2025-08-05T20:09:21Z

Looks like we are seeing drift for in the new autopilot example's network:

Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206: Terraform will perform the following actions:
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206: 
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206:   # module.example.module.gcp-network.module.subnets.google_compute_subnetwork.subnetwork["us-central1/autopilot-subnet"] will be updated in-place
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206:   ~ resource "google_compute_subnetwork" "subnetwork" {
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206:         id                         = "projects/ci-gke-6984750c-d3ac/regions/us-central1/subnetworks/autopilot-subnet"
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206:         name                       = "autopilot-subnet"
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206:         # (22 unchanged attributes hidden)
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206: 
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206:       - secondary_ip_range {
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206:           - ip_cidr_range           = "10.2.0.0/17" -> null
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206:           - range_name              = "gke-gke-autopilot-cluster-pods-9ef2a7f5" -> null
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206:           - reserved_internal_range = "https://networkconnectivity.googleapis.com/v1/projects/ci-gke-6984750c-d3ac/locations/global/internalRanges/gke-gke-autopilot-cluster-pods-9ef2a7f5" -> null
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206:         }
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206: 
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206:         # (2 unchanged blocks hidden)
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206:     }
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206: 
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206: Plan: 0 to add, 1 to change, 0 to destroy.
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206: 
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206: â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€â”€
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206: 
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206: Note: You didn't use the -out option to save this plan, so Terraform can't
Step #52 - "verify gke-autopilot-cluster": TestGKEAutopilotCluster 2025-08-05T19:17:07Z command.go:206: guarantee to take exactly these actions if you run "terraform apply" now.
Step #52 - "verify gke-autopilot-cluster":     terraform.go:537: 
Step #52 - "verify gke-autopilot-cluster":         	Error Trace:	/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:537
Step #52 - "verify gke-autopilot-cluster":         	            				/workspace/test/integration/gke_autopilot_cluster/gke_autopilot_cluster_test.go:33
Step #52 - "verify gke-autopilot-cluster":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:638
Step #52 - "verify gke-autopilot-cluster":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:670
Step #52 - "verify gke-autopilot-cluster":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/utils/stages.go:31
Step #52 - "verify gke-autopilot-cluster":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:670
Step #52 - "verify gke-autopilot-cluster":         	Error:      	Should not be: 2
Step #52 - "verify gke-autopilot-cluster":         	Test:       	TestGKEAutopilotCluster
Step #52 - "verify gke-autopilot-cluster":         	Messages:   	plan after apply should have no diff

apeabody · 2025-08-05T20:10:22Z

re-triggered in case it was transitory

daniel-cit · 2025-08-05T22:39:47Z

@apeabody all green :)

apeabody

Thanks @daniel-cit!

daniel-cit added 6 commits August 4, 2025 19:08

feat: add simple gke modules for ADC

f6d1e33

Merge remote-tracking branch 'origin/main' into simple-gke-modules

2a7ea08

update metadata.yaml

74fb07e

serialize new integration tests

2f9c2cf

add new default response field maxParallelImagePulls to kubeletConfig…

1e64597

… of golden file in private_zonal_with_networking_test

add RECONCILING in valid status options after deploy

7545041

apeabody reviewed Aug 5, 2025

View reviewed changes

apeabody self-assigned this Aug 5, 2025

daniel-cit added 3 commits August 5, 2025 14:06

add RECONCILING in valid status options after deploy for upstream nam…

06e951d

…eservers example

code review fixes

54d2e96

add RECONCILING in valid status options after deploy for global verify

9de9494

daniel-cit marked this pull request as ready for review August 5, 2025 19:16

daniel-cit requested review from a team and ericyz as code owners August 5, 2025 19:16

user ip_allocation_policy to set range names

952eed2

apeabody approved these changes Aug 5, 2025

View reviewed changes

apeabody merged commit 1859b17 into terraform-google-modules:main Aug 5, 2025
4 checks passed

release-please bot mentioned this pull request Aug 5, 2025

chore(main): release 38.0.0 #2390

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Simple GKE modules for ADC #2397

feat: Simple GKE modules for ADC #2397

Uh oh!

daniel-cit commented Aug 4, 2025

Uh oh!

daniel-cit commented Aug 5, 2025

Uh oh!

apeabody left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daniel-cit commented Aug 5, 2025

Uh oh!

apeabody commented Aug 5, 2025

Uh oh!

apeabody commented Aug 5, 2025

Uh oh!

apeabody commented Aug 5, 2025

Uh oh!

daniel-cit commented Aug 5, 2025

Uh oh!

apeabody left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: Simple GKE modules for ADC #2397

feat: Simple GKE modules for ADC #2397

Uh oh!

Conversation

daniel-cit commented Aug 4, 2025

Uh oh!

daniel-cit commented Aug 5, 2025

Uh oh!

apeabody left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daniel-cit commented Aug 5, 2025

Uh oh!

apeabody commented Aug 5, 2025

Uh oh!

apeabody commented Aug 5, 2025

Uh oh!

apeabody commented Aug 5, 2025

Uh oh!

daniel-cit commented Aug 5, 2025

Uh oh!

apeabody left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants