feat(TPG >= 6.47)!: add support for lustre csi driver #2427
Conversation
apeabody
changed the title
apeabody
left a comment
apeabody
left a comment
There was a problem hiding this comment.
Thanks for the contribution @imrannayer!
A few notes below.
| -e ENABLE_BPMETADATA=1 \ | ||
| -v "$(CURDIR)":/workspace \ | ||
| $(REGISTRY_URL)/${DOCKER_IMAGE_DEVELOPER_TOOLS}:${DOCKER_TAG_VERSION_DEVELOPER_TOOLS} \ | ||
| /bin/bash -c 'source /usr/local/bin/task_helper_functions.sh && generate_docs --per-module-requirements' |
There was a problem hiding this comment.
Hi @imrannayer - We use --per-module-requirements for this repo.
There was a problem hiding this comment.
@apeabody I am getting error saying this is not a valid option.
There was a problem hiding this comment.
Ahh, I suspect you have a cached (old) version of dev-tools. Can you clear to force a download and re-try?
| google = { | ||
| source = "hashicorp/google" | ||
| version = ">= 6.42.0, < 7" | ||
| version = ">= 6.47.0, < 7" |
There was a problem hiding this comment.
Can you please update the README to match, and add an upgrade guide similar to https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/main/docs/upgrading_to_v38.0.md
| # due to https://github.com/hashicorp/terraform-provider-google/issues/9505 for AP | ||
| default_service_account = "keep" | ||
|
|
||
| deletion_policy = "DELETE" |
There was a problem hiding this comment.
Why is this now needed?
(the lint is also failing on the extra spaces)
There was a problem hiding this comment.
I can remove it. I just added since we have it in majority of the modules.
There was a problem hiding this comment.
We can keep, looks like this was semi-recent change in terraform-google-modules/project-factory/google behavior. Just needs a terraform fmt
|
created PR #2433. Closing this one |
2 participants
No description provided.