-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add support for anonymous_authentication_config #2436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for anonymous_authentication_config #2436
Conversation
|
/gcbrun |
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @DrFaust92!
Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/cluster.tf /tmp/tmp.BQLJdIFYWI/workspace/cluster.tf
216d215
<
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes
2388920 to
ee5d2bc
Compare
done |
ee5d2bc to
4e2461f
Compare
|
/gcbrun |
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
f852361 to
41b1b72
Compare
|
/gcbrun |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for anonymous_authentication_config by adding the anonymous_authentication_config_mode variable. The changes are consistently applied across the root module and all relevant submodules, including updates to documentation and metadata. The implementation is straightforward and correct. My only suggestion is to add a validation block to the new variable in all variables.tf files to ensure only valid values (ENABLED or LIMITED) are used, which will improve the module's robustness against misconfiguration.
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @DrFaust92!
No description provided.