Skip to content

Conversation

@DrFaust92
Copy link
Contributor

No description provided.

@DrFaust92 DrFaust92 requested review from a team, apeabody and ericyz as code owners September 4, 2025 22:57
@DrFaust92 DrFaust92 changed the title add support for anonymous_authentication_config feat: add support for anonymous_authentication_config Sep 4, 2025
@apeabody
Copy link
Collaborator

apeabody commented Sep 8, 2025

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/cluster.tf /tmp/tmp.BQLJdIFYWI/workspace/cluster.tf
216d215
< 
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes

@DrFaust92 DrFaust92 force-pushed the anonymous_authentication_config branch from 2388920 to ee5d2bc Compare September 16, 2025 22:49
@DrFaust92 DrFaust92 requested a review from apeabody September 16, 2025 22:50
@DrFaust92
Copy link
Contributor Author

Thanks for the contribution @DrFaust92!

Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/cluster.tf /tmp/tmp.BQLJdIFYWI/workspace/cluster.tf
216d215
< 
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes

done

@DrFaust92 DrFaust92 force-pushed the anonymous_authentication_config branch from ee5d2bc to 4e2461f Compare September 19, 2025 20:59
@apeabody
Copy link
Collaborator

/gcbrun

@DrFaust92 DrFaust92 force-pushed the anonymous_authentication_config branch from f852361 to 41b1b72 Compare September 28, 2025 01:39
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Oct 1, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for anonymous_authentication_config by adding the anonymous_authentication_config_mode variable. The changes are consistently applied across the root module and all relevant submodules, including updates to documentation and metadata. The implementation is straightforward and correct. My only suggestion is to add a validation block to the new variable in all variables.tf files to ensure only valid values (ENABLED or LIMITED) are used, which will improve the module's robustness against misconfiguration.

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

@apeabody apeabody merged commit f27a2dd into terraform-google-modules:main Oct 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants