-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add support for NAP/autopilot resource manager tags #2447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for NAP/autopilot resource manager tags #2447
Conversation
6ddcc03 to
2c2393a
Compare
|
/gcbrun |
|
@apeabody would you like me to add a new test or two for this change? Or I could add the new field to one or more existing tests if you'd like. I got the test projects set up and ran the tests in a sandbox org. All the tests in build/int.cloudbuild.yaml passed (I put them in a shell script with |
Thanks @pib! - The current test failure does not appear to be related to your change and can be re-run. That said we should add test coverage to an existing example, likely |
|
@apeabody I have added it to the node_pool test. Rather than putting the new field in the golden file, I had to check for it explicitly in the test because testutils.TGKEAssertGolden doesn't handle having values that need to be sanitized in map keys. |
|
/gcbrun |
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @pib!
Fixes #2330