fix: use null comparators in cases where zero or false are meaningful

autogen/main/cluster.tf.tmpl

@@ -1096,7 +1096,7 @@ resource "google_container_node_pool" "windows_pools" {
   }
 
   dynamic "queued_provisioning" {
-    for_each = lookup(each.value, "queued_provisioning", false) ? [true] : []
+    for_each = lookup(each.value, "queued_provisioning", null) != null ? [true] : []
     content {
       enabled = lookup(each.value, "queued_provisioning", null)
     }
@@ -1258,9 +1258,9 @@ resource "google_container_node_pool" "windows_pools" {
     }
 
     dynamic "advanced_machine_features" {
-      for_each = lookup(each.value, "threads_per_core", 0) > 0 || lookup(each.value, "enable_nested_virtualization", false) || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
+      for_each = lookup(each.value, "threads_per_core", null) != null || lookup(each.value, "enable_nested_virtualization", null) != null || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
       content {
-        threads_per_core             = lookup(each.value, "threads_per_core", 0)
+        threads_per_core             = lookup(each.value, "threads_per_core", null)
         enable_nested_virtualization = lookup(each.value, "enable_nested_virtualization", null)
         performance_monitoring_unit  = lookup(each.value, "performance_monitoring_unit", null)
       }

cluster.tf

@@ -805,7 +805,7 @@ resource "google_container_node_pool" "pools" {
   }
 
   dynamic "queued_provisioning" {
-    for_each = lookup(each.value, "queued_provisioning", false) ? [true] : []
+    for_each = lookup(each.value, "queued_provisioning", null) != null ? [true] : []
     content {
       enabled = lookup(each.value, "queued_provisioning", null)
     }
@@ -959,9 +959,9 @@ resource "google_container_node_pool" "pools" {
     }
 
     dynamic "advanced_machine_features" {
-      for_each = lookup(each.value, "threads_per_core", 0) > 0 || lookup(each.value, "enable_nested_virtualization", false) || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
+      for_each = lookup(each.value, "threads_per_core", null) != null || lookup(each.value, "enable_nested_virtualization", null) != null || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
       content {
-        threads_per_core             = lookup(each.value, "threads_per_core", 0)
+        threads_per_core             = lookup(each.value, "threads_per_core", null)
         enable_nested_virtualization = lookup(each.value, "enable_nested_virtualization", null)
         performance_monitoring_unit  = lookup(each.value, "performance_monitoring_unit", null)
       }
@@ -1185,7 +1185,7 @@ resource "google_container_node_pool" "windows_pools" {
   }
 
   dynamic "queued_provisioning" {
-    for_each = lookup(each.value, "queued_provisioning", false) ? [true] : []
+    for_each = lookup(each.value, "queued_provisioning", null) != null ? [true] : []
     content {
       enabled = lookup(each.value, "queued_provisioning", null)
     }
@@ -1339,9 +1339,9 @@ resource "google_container_node_pool" "windows_pools" {
     }
 
     dynamic "advanced_machine_features" {
-      for_each = lookup(each.value, "threads_per_core", 0) > 0 || lookup(each.value, "enable_nested_virtualization", false) || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
+      for_each = lookup(each.value, "threads_per_core", null) != null || lookup(each.value, "enable_nested_virtualization", null) != null || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
       content {
-        threads_per_core             = lookup(each.value, "threads_per_core", 0)
+        threads_per_core             = lookup(each.value, "threads_per_core", null)
         enable_nested_virtualization = lookup(each.value, "enable_nested_virtualization", null)
         performance_monitoring_unit  = lookup(each.value, "performance_monitoring_unit", null)
       }

metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/auth/metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/auth/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/beta-autopilot-private-cluster/metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/beta-autopilot-private-cluster/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/beta-autopilot-public-cluster/metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/beta-autopilot-public-cluster/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/beta-private-cluster-update-variant/cluster.tf

@@ -949,7 +949,7 @@ resource "google_container_node_pool" "pools" {
   }
 
   dynamic "queued_provisioning" {
-    for_each = lookup(each.value, "queued_provisioning", false) ? [true] : []
+    for_each = lookup(each.value, "queued_provisioning", null) != null ? [true] : []
     content {
       enabled = lookup(each.value, "queued_provisioning", null)
     }
@@ -1109,9 +1109,9 @@ resource "google_container_node_pool" "pools" {
     }
 
     dynamic "advanced_machine_features" {
-      for_each = lookup(each.value, "threads_per_core", 0) > 0 || lookup(each.value, "enable_nested_virtualization", false) || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
+      for_each = lookup(each.value, "threads_per_core", null) != null || lookup(each.value, "enable_nested_virtualization", null) != null || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
       content {
-        threads_per_core             = lookup(each.value, "threads_per_core", 0)
+        threads_per_core             = lookup(each.value, "threads_per_core", null)
         enable_nested_virtualization = lookup(each.value, "enable_nested_virtualization", null)
         performance_monitoring_unit  = lookup(each.value, "performance_monitoring_unit", null)
       }
@@ -1343,7 +1343,7 @@ resource "google_container_node_pool" "windows_pools" {
   }
 
   dynamic "queued_provisioning" {
-    for_each = lookup(each.value, "queued_provisioning", false) ? [true] : []
+    for_each = lookup(each.value, "queued_provisioning", null) != null ? [true] : []
     content {
       enabled = lookup(each.value, "queued_provisioning", null)
     }
@@ -1503,9 +1503,9 @@ resource "google_container_node_pool" "windows_pools" {
     }
 
     dynamic "advanced_machine_features" {
-      for_each = lookup(each.value, "threads_per_core", 0) > 0 || lookup(each.value, "enable_nested_virtualization", false) || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
+      for_each = lookup(each.value, "threads_per_core", null) != null || lookup(each.value, "enable_nested_virtualization", null) != null || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
       content {
-        threads_per_core             = lookup(each.value, "threads_per_core", 0)
+        threads_per_core             = lookup(each.value, "threads_per_core", null)
         enable_nested_virtualization = lookup(each.value, "enable_nested_virtualization", null)
         performance_monitoring_unit  = lookup(each.value, "performance_monitoring_unit", null)
       }

modules/beta-private-cluster-update-variant/metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/beta-private-cluster-update-variant/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/beta-private-cluster/cluster.tf

@@ -863,7 +863,7 @@ resource "google_container_node_pool" "pools" {
   }
 
   dynamic "queued_provisioning" {
-    for_each = lookup(each.value, "queued_provisioning", false) ? [true] : []
+    for_each = lookup(each.value, "queued_provisioning", null) != null ? [true] : []
     content {
       enabled = lookup(each.value, "queued_provisioning", null)
     }
@@ -1023,9 +1023,9 @@ resource "google_container_node_pool" "pools" {
     }
 
     dynamic "advanced_machine_features" {
-      for_each = lookup(each.value, "threads_per_core", 0) > 0 || lookup(each.value, "enable_nested_virtualization", false) || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
+      for_each = lookup(each.value, "threads_per_core", null) != null || lookup(each.value, "enable_nested_virtualization", null) != null || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
       content {
-        threads_per_core             = lookup(each.value, "threads_per_core", 0)
+        threads_per_core             = lookup(each.value, "threads_per_core", null)
         enable_nested_virtualization = lookup(each.value, "enable_nested_virtualization", null)
         performance_monitoring_unit  = lookup(each.value, "performance_monitoring_unit", null)
       }
@@ -1256,7 +1256,7 @@ resource "google_container_node_pool" "windows_pools" {
   }
 
   dynamic "queued_provisioning" {
-    for_each = lookup(each.value, "queued_provisioning", false) ? [true] : []
+    for_each = lookup(each.value, "queued_provisioning", null) != null ? [true] : []
     content {
       enabled = lookup(each.value, "queued_provisioning", null)
     }
@@ -1416,9 +1416,9 @@ resource "google_container_node_pool" "windows_pools" {
     }
 
     dynamic "advanced_machine_features" {
-      for_each = lookup(each.value, "threads_per_core", 0) > 0 || lookup(each.value, "enable_nested_virtualization", false) || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
+      for_each = lookup(each.value, "threads_per_core", null) != null || lookup(each.value, "enable_nested_virtualization", null) != null || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
       content {
-        threads_per_core             = lookup(each.value, "threads_per_core", 0)
+        threads_per_core             = lookup(each.value, "threads_per_core", null)
         enable_nested_virtualization = lookup(each.value, "enable_nested_virtualization", null)
         performance_monitoring_unit  = lookup(each.value, "performance_monitoring_unit", null)
       }

modules/beta-private-cluster/metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/beta-private-cluster/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/beta-public-cluster-update-variant/cluster.tf

@@ -927,7 +927,7 @@ resource "google_container_node_pool" "pools" {
   }
 
   dynamic "queued_provisioning" {
-    for_each = lookup(each.value, "queued_provisioning", false) ? [true] : []
+    for_each = lookup(each.value, "queued_provisioning", null) != null ? [true] : []
     content {
       enabled = lookup(each.value, "queued_provisioning", null)
     }
@@ -1087,9 +1087,9 @@ resource "google_container_node_pool" "pools" {
     }
 
     dynamic "advanced_machine_features" {
-      for_each = lookup(each.value, "threads_per_core", 0) > 0 || lookup(each.value, "enable_nested_virtualization", false) || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
+      for_each = lookup(each.value, "threads_per_core", null) != null || lookup(each.value, "enable_nested_virtualization", null) != null || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
       content {
-        threads_per_core             = lookup(each.value, "threads_per_core", 0)
+        threads_per_core             = lookup(each.value, "threads_per_core", null)
         enable_nested_virtualization = lookup(each.value, "enable_nested_virtualization", null)
         performance_monitoring_unit  = lookup(each.value, "performance_monitoring_unit", null)
       }
@@ -1321,7 +1321,7 @@ resource "google_container_node_pool" "windows_pools" {
   }
 
   dynamic "queued_provisioning" {
-    for_each = lookup(each.value, "queued_provisioning", false) ? [true] : []
+    for_each = lookup(each.value, "queued_provisioning", null) != null ? [true] : []
     content {
       enabled = lookup(each.value, "queued_provisioning", null)
     }
@@ -1481,9 +1481,9 @@ resource "google_container_node_pool" "windows_pools" {
     }
 
     dynamic "advanced_machine_features" {
-      for_each = lookup(each.value, "threads_per_core", 0) > 0 || lookup(each.value, "enable_nested_virtualization", false) || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
+      for_each = lookup(each.value, "threads_per_core", null) != null || lookup(each.value, "enable_nested_virtualization", null) != null || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
       content {
-        threads_per_core             = lookup(each.value, "threads_per_core", 0)
+        threads_per_core             = lookup(each.value, "threads_per_core", null)
         enable_nested_virtualization = lookup(each.value, "enable_nested_virtualization", null)
         performance_monitoring_unit  = lookup(each.value, "performance_monitoring_unit", null)
       }

modules/beta-public-cluster-update-variant/metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/beta-public-cluster-update-variant/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/beta-public-cluster/cluster.tf

@@ -841,7 +841,7 @@ resource "google_container_node_pool" "pools" {
   }
 
   dynamic "queued_provisioning" {
-    for_each = lookup(each.value, "queued_provisioning", false) ? [true] : []
+    for_each = lookup(each.value, "queued_provisioning", null) != null ? [true] : []
     content {
       enabled = lookup(each.value, "queued_provisioning", null)
     }
@@ -1001,9 +1001,9 @@ resource "google_container_node_pool" "pools" {
     }
 
     dynamic "advanced_machine_features" {
-      for_each = lookup(each.value, "threads_per_core", 0) > 0 || lookup(each.value, "enable_nested_virtualization", false) || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
+      for_each = lookup(each.value, "threads_per_core", null) != null || lookup(each.value, "enable_nested_virtualization", null) != null || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
       content {
-        threads_per_core             = lookup(each.value, "threads_per_core", 0)
+        threads_per_core             = lookup(each.value, "threads_per_core", null)
         enable_nested_virtualization = lookup(each.value, "enable_nested_virtualization", null)
         performance_monitoring_unit  = lookup(each.value, "performance_monitoring_unit", null)
       }
@@ -1234,7 +1234,7 @@ resource "google_container_node_pool" "windows_pools" {
   }
 
   dynamic "queued_provisioning" {
-    for_each = lookup(each.value, "queued_provisioning", false) ? [true] : []
+    for_each = lookup(each.value, "queued_provisioning", null) != null ? [true] : []
     content {
       enabled = lookup(each.value, "queued_provisioning", null)
     }
@@ -1394,9 +1394,9 @@ resource "google_container_node_pool" "windows_pools" {
     }
 
     dynamic "advanced_machine_features" {
-      for_each = lookup(each.value, "threads_per_core", 0) > 0 || lookup(each.value, "enable_nested_virtualization", false) || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
+      for_each = lookup(each.value, "threads_per_core", null) != null || lookup(each.value, "enable_nested_virtualization", null) != null || lookup(each.value, "performance_monitoring_unit", null) != null ? [1] : []
       content {
-        threads_per_core             = lookup(each.value, "threads_per_core", 0)
+        threads_per_core             = lookup(each.value, "threads_per_core", null)
         enable_nested_virtualization = lookup(each.value, "enable_nested_virtualization", null)
         performance_monitoring_unit  = lookup(each.value, "performance_monitoring_unit", null)
       }

modules/beta-public-cluster/metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/beta-public-cluster/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/binary-authorization/metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/binary-authorization/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/fleet-app-operator-permissions/metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/fleet-app-operator-permissions/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/fleet-membership/metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/fleet-membership/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/gke-autopilot-cluster/metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/gke-autopilot-cluster/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -573,9 +573,9 @@ spec:
     roles:
       - level: Project
         roles:
+          - roles/iam.serviceAccountUser
           - roles/compute.admin
           - roles/container.admin
-          - roles/iam.serviceAccountUser
     services:
       - compute.googleapis.com
       - container.googleapis.com

modules/gke-node-pool/metadata.display.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

modules/gke-node-pool/metadata.yaml

@@ -1,4 +1,4 @@
-# Copyright 2025 Google LLC
+# Copyright 2026 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.