fix!: Adding regex validation for service name and adding apphub #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrkk123
requested review from
a team,
ayushmjain,
imrannayer and
q2w
as code owners
q2w
reviewed
Jul 28, 2025
Collaborator
q2w
left a comment
q2w
left a comment
There was a problem hiding this comment.
Thanks!
- please validate the service_uri format being introduced here.
- please validate if changing the neg name would not trigger delete/create.
modules/frontend/outputs.tf
Outdated
| } | ||
|
|
||
| output "apphub_service_uri" { | ||
| value = { |
Collaborator
There was a problem hiding this comment.
Can we keep this list of object like it is in regional LB?
modules/frontend/outputs.tf
Outdated
| output "apphub_service_uri" { | ||
| value = { | ||
| service_uri = "//compute.googleapis.com/${google_compute_forwarding_rule.default[0].id}" | ||
| service_id = substr("${google_compute_forwarding_rule.default[0].name}-${md5("global-${var.project_id}")}", 0, 63) |
Collaborator
There was a problem hiding this comment.
Suggested change
| service_id = substr("${google_compute_forwarding_rule.default[0].name}-${md5("global-${var.project_id}")}", 0, 63) | |
| service_id = substr("${google_compute_forwarding_rule.default[0].name}-${md5("global-lb-${var.project_id}")}", 0, 63) |
modules/backend/outputs.tf
Outdated
| } | ||
|
|
||
| output "apphub_service_uri" { | ||
| value = { |
Collaborator
There was a problem hiding this comment.
Can we keep this as list of object. I see you already have the type in metadata.yaml as list of object.
modules/backend/outputs.tf
Outdated
| output "apphub_service_uri" { | ||
| value = { | ||
| service_uri = "//compute.googleapis.com/${google_compute_backend_service.default[0].id}" | ||
| service_id = substr("${google_compute_backend_service.default[0].name}-${md5("global-${var.project_id}")}", 0, 63) |
Collaborator
There was a problem hiding this comment.
Suggested change
| service_id = substr("${google_compute_backend_service.default[0].name}-${md5("global-${var.project_id}")}", 0, 63) | |
| service_id = substr("${google_compute_backend_service.default[0].name}-${md5("global-be-service-${var.project_id}")}", 0, 63) |
modules/backend/main.tf
Outdated
| for_each = toset(var.serverless_neg_backends) | ||
| content { | ||
| group = google_compute_region_network_endpoint_group.serverless_negs["neg-${var.name}-${backend.value.service_name}-${backend.value.region}"].id | ||
| group = google_compute_region_network_endpoint_group.serverless_negs["neg-${var.name}-${substr(sha256(backend.value.service_name), 0, 4)}-${backend.value.region}"].id |
Collaborator
There was a problem hiding this comment.
Suggested change
| group = google_compute_region_network_endpoint_group.serverless_negs["neg-${var.name}-${substr(sha256(backend.value.service_name), 0, 4)}-${backend.value.region}"].id | |
| group = google_compute_region_network_endpoint_group.serverless_negs["neg-${var.name}-${backend.value.region}-${substr(md5(backend.value.service_name), 0, 4)}"].id |
Collaborator
There was a problem hiding this comment.
You would need to change NEG resource name similarly.
q2w
changed the title
q2w
approved these changes
Jul 30, 2025
Collaborator
|
Marking this a breaking change as it updates serverless_negs name within modules/backend. this would trigger delete/create behavior. |
auto-merge was automatically disabled
July 30, 2025 10:28
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.