Skip to content

Conversation

@tjy9206
Copy link
Contributor

@tjy9206 tjy9206 commented Oct 16, 2024

No description provided.

@tjy9206 tjy9206 requested review from a team, imrannayer and q2w as code owners October 16, 2024 20:23
tjy9206 and others added 2 commits October 18, 2024 14:49
Co-authored-by: abhishek kumar tiwari <[email protected]>
Co-authored-by: abhishek kumar tiwari <[email protected]>
@q2w
Copy link
Collaborator

q2w commented Oct 22, 2024

/gcbrun

@q2w q2w self-requested a review October 22, 2024 13:07
@q2w
Copy link
Collaborator

q2w commented Oct 22, 2024

/gcbrun

2 similar comments
@q2w
Copy link
Collaborator

q2w commented Oct 23, 2024

/gcbrun

@imrannayer
Copy link
Collaborator

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this PR modifies a .tf file, I would recommend calling as a "fix". That way it will included it in the release notes, and more importantly, if one doesn't exist, triggers the creation of a new release PR ("chore" do not).

@tjy9206 tjy9206 changed the title chore: Add Apphub URI output to Redis fix: Add Apphub URI output to Redis Oct 23, 2024
@q2w q2w merged commit dc74494 into terraform-google-modules:master Oct 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants