Skip to content

feat(TPG>6.0)!: Add support for reserved_internal_range in secondary IP ranges#640

Open
mclavel wants to merge 5 commits intoterraform-google-modules:mainfrom
mclavel:main
Open

feat(TPG>6.0)!: Add support for reserved_internal_range in secondary IP ranges#640
mclavel wants to merge 5 commits intoterraform-google-modules:mainfrom
mclavel:main

Conversation

@mclavel
Copy link

@mclavel mclavel commented Oct 11, 2025

This PR adds support for the reserved_internal_range field in subnet secondary ranges

@mclavel mclavel requested review from a team and imrannayer as code owners October 11, 2025 05:49
@google-cla
Copy link

google-cla bot commented Oct 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mclavel
Copy link
Author

mclavel commented Oct 14, 2025

@imrannayer 👀

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mclavel

@bharathkkb bharathkkb changed the title feat: Add support for reserved_internal_range in secondary IP ranges feat!: Add support for reserved_internal_range in secondary IP ranges Oct 17, 2025
@mclavel mclavel requested a review from bharathkkb October 19, 2025 16:51
@imrannayer imrannayer changed the title feat!: Add support for reserved_internal_range in secondary IP ranges feat(TPG>6.0)!: Add support for reserved_internal_range in secondary IP ranges Nov 12, 2025
@imrannayer
Copy link
Collaborator

/gcbrun

@github-actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jan 11, 2026
@imrannayer
Copy link
Collaborator

/gcbrun

@github-actions github-actions bot removed the Stale label Jan 12, 2026
@imrannayer
Copy link
Collaborator

imrannayer commented Jan 13, 2026

@mclavel this part of the test is failing

TestSecondaryRanges 2026-01-12T16:40:09Z command.go:123: Running command gcloud with args [compute networks subnets describe secondary-ranges-a1-subnet-03 --project ci-network-d51f --region us-west1 --format json]
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212: {
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "allowSubnetCidrRoutesOverlap": false,
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "creationTimestamp": "2026-01-12T08:37:52.727-08:00",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "enableFlowLogs": true,
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "fingerprint": "7bCQ9Nc0Vww=",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "gatewayAddress": "10.10.30.1",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "id": "2092581294592007567",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "ipCidrRange": "10.10.30.0/24",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "kind": "compute#subnetwork",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "logConfig": {
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:     "aggregationInterval": "INTERVAL_15_MIN",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:     "enable": true,
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:     "filterExpr": "true",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:     "flowSampling": 0.9,
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:     "metadata": "INCLUDE_ALL_METADATA"
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   },
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "name": "secondary-ranges-a1-subnet-03",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "network": "https://www.googleapis.com/compute/v1/projects/ci-network-d51f/global/networks/secondary-ranges-a1",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "privateIpGoogleAccess": false,
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "privateIpv6GoogleAccess": "DISABLE_GOOGLE_ACCESS",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "purpose": "PRIVATE",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "region": "https://www.googleapis.com/compute/v1/projects/ci-network-d51f/regions/us-west1",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "secondaryIpRanges": [
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:     {
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:       "ipCidrRange": "192.168.66.0/24",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:       "rangeName": "secondary-ranges-a1-subnet-03-01"
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:     },
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:     {
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:       "ipCidrRange": "172.16.0.0/24",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:       "rangeName": "secondary-ranges-a1-subnet-03-02",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:       "reservedInternalRange": "https://networkconnectivity.googleapis.com/v1/projects/ci-network-d51f/locations/global/internalRanges/secondary-ranges-a1-internal-range"
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:     }
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   ],
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "selfLink": "https://www.googleapis.com/compute/v1/projects/ci-network-d51f/regions/us-west1/subnetworks/secondary-ranges-a1-subnet-03",
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212:   "stackType": "IPV4_ONLY"
TestSecondaryRanges 2026-01-12T16:40:18Z command.go:212: }
    secondary_ranges_test.go:40: 
        	Error Trace:	/workspace/test/integration/secondary_ranges/secondary_ranges_test.go:40
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/blueprint-test@v0.17.9/pkg/tft/terraform.go:638
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/blueprint-test@v0.17.9/pkg/tft/terraform.go:670
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/blueprint-test@v0.17.9/pkg/utils/stages.go:31
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/blueprint-test@v0.17.9/pkg/tft/terraform.go:670
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 2
        	Test:       	TestSecondaryRanges
        	Messages:   	has expected number of secondary ranges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants