feat(TPG>7.8)!: ncc preset topology #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
paulwilljones
force-pushed
the
feat/ncc-preset-topology
branch
from
f65f13d to
9c37fd9
Compare
imrannayer
reviewed
Oct 17, 2025
imrannayer
reviewed
Oct 17, 2025
Collaborator
|
@paulwilljones thank you for the PR. can you plz change min version to 6.9 in versions.tf file (google_network_connectivity_group was part of 6.9). This will be a breaking change due to min provider version change. Can you plz add a document in doc folder. |
imrannayer
changed the title
paulwilljones
force-pushed
the
feat/ncc-preset-topology
branch
2 times, most recently
from
44d26f2 to
6a89ece
Compare
add integration test for ncc star groups add upgrading docs bump ncc module provider version
paulwilljones
force-pushed
the
feat/ncc-preset-topology
branch
from
6a89ece to
2f7ef6e
Compare
imrannayer
reviewed
Oct 20, 2025
imrannayer
reviewed
Oct 20, 2025
paulwilljones
force-pushed
the
feat/ncc-preset-topology
branch
from
96b085b to
ab7ab80
Compare
paulwilljones
force-pushed
the
feat/ncc-preset-topology
branch
from
ab7ab80 to
78f7f45
Compare
Collaborator
|
/gcbrun |
imrannayer
reviewed
Oct 21, 2025
imrannayer
reviewed
Oct 22, 2025
test/integration/network_connectivity_center/network_connectivity_center_test.go
Show resolved
Hide resolved
imrannayer
reviewed
Oct 23, 2025
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
imrannayer
changed the title
imrannayer
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.