chore: remove require_ssl from examples#673
Merged
imrannayer merged 6 commits intoterraform-google-modules:mainfrom Jan 29, 2025
Merged
chore: remove require_ssl from examples#673imrannayer merged 6 commits intoterraform-google-modules:mainfrom
imrannayer merged 6 commits intoterraform-google-modules:mainfrom
Conversation
ckluente-1k5
requested review from
a team,
imrannayer,
isaurabhuttam and
q2w
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
@ckluente-1k5 thx for the PR. As of 6.01 require_ssl parameter has been removed. It was removed from the module. We need to remove it from doc and example. |
imrannayer
changed the title
Collaborator
|
/gcbrun |
Collaborator
|
@ckluente-1k5 integration test is failing. Can you plz replace |
Collaborator
|
/gcbrun |
imrannayer
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sorry for this "docs only" PR. But since require_ssl does not do anything, I thought it might be important to fix this before people are surprised that their database still allows unencrypted connections although stated differently in their code.