feat: Making IPSEC PSK length configurable #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
shivamverma182
changed the title
Contributor
Author
|
/gcbrun |
1 similar comment
Collaborator
|
/gcbrun |
imrannayer
approved these changes
Nov 12, 2024
aglshiv
added a commit
to fairmoney/terraform-google-vpn
that referenced
this pull request
Jan 20, 2025
* chore(deps): update go and dev-tools (terraform-google-modules#139) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update examples to use registry (terraform-google-modules#142) * chore(deps): Update module github.com/GoogleCloudPlatform/cloud-foundation-toolkit/infra/blueprint-test to v0.10.3 (terraform-google-modules#140) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update .github/workflows/lint.yaml * chore(deps): Update module github.com/GoogleCloudPlatform/cloud-foundation-toolkit/infra/blueprint-test to v0.11.1 (terraform-google-modules#144) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update .github/workflows/stale.yml * chore: update .github/workflows/stale.yml * chore: update CODEOWNERS * chore: update .github/workflows/lint.yaml * chore(deps): Update go modules and/or dev-tools (terraform-google-modules#149) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): Update module github.com/GoogleCloudPlatform/cloud-foundation-toolkit/infra/blueprint-test to v0.13.2 (terraform-google-modules#151) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): Update go modules and dev-tools (terraform-google-modules#153) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: mark secret outputs sensitive for classic vpn Ref: terraform-google-modules#158 (terraform-google-modules#159) * chore(deps): Update go modules and dev-tools (terraform-google-modules#156) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): Update Terraform terraform-google-modules/project-factory/google to v15 (terraform-google-modules#157) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(master): release 4.0.1 (terraform-google-modules#161) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore(deps): Update go modules and dev-tools (terraform-google-modules#162) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(deps): Update Terraform Google Provider to v6 (major) (terraform-google-modules#166) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(master): release 4.1.0 (terraform-google-modules#167) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore(deps): Update go modules and/or dev-tools (terraform-google-modules#163) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): Update Terraform terraform-google-modules/project-factory/google to v17 (terraform-google-modules#168) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: Making IPSEC PSK length configurable (terraform-google-modules#171) * chore(master): release 4.2.0 (terraform-google-modules#172) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: update .github/conventional-commit-lint.yaml * chore: update .github/workflows/stale.yml * chore: update .github/trusted-contribution.yml * chore: update .github/renovate.json * chore: update CODEOWNERS * chore: update .github/workflows/lint.yaml * chore: update .github/trusted-contribution.yml * chore: update .github/workflows/lint.yaml * chore: update .github/workflows/stale.yml * chore: update CODEOWNERS * chore: update .github/conventional-commit-lint.yaml --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Bharath KKB <[email protected]> Co-authored-by: CFT Bot <[email protected]> Co-authored-by: qbaze <[email protected]> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Shivam Verma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPSEC PSK secret is hardcoded to length 8 which is not sufficient in production and may want longer secret. So raising this PR to make the length configurable. I've run the lint test. Attached is the screenshot.