generated from terraform-ibm-modules/stack-ibm-template
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: existing scc instance for DA #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 24 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
8c1e146
feat: existing scc instance for DA
9f33ef3
feat: existing scc instance for DA
18e6c2e
Merge branch 'main' into existing-scc
jor2 847a824
feat: add existing scc instance config
2e91314
feat: add existing scc instance config
ed858b3
feat: add existing scc instance config
4f45e90
Merge branch 'main' into existing-scc
jor2 781f6b4
Merge branch 'main' into existing-scc
jor2 eec97ff
Merge branch 'main' of github.com:terraform-ibm-modules/stack-ibm-cor…
2639af6
Merge branch 'main' into existing-scc
jor2 adc2bc9
Merge branch 'main' into existing-scc
jor2 0592e4d
Merge branch 'existing-scc' of github.com:terraform-ibm-modules/stack…
4c7446d
fix: key name
bd26001
fix: module named
9980af9
fix: module named
4ee96d6
Update stack_definition.json
jor2 be578a9
Merge branch 'main' into existing-scc
jor2 1e4cb9c
Update stack_definition.json
jor2 527022a
Update stack_definition.json
jor2 d06c02b
Update stack_definition.json
jor2 1e79df0
Merge branch 'main' into existing-scc
jor2 4ada1f8
fix: add more vars
6db4def
Merge branch 'main' into existing-scc
jor2 66178ef
Merge branch 'main' into existing-scc
jor2 ab7c667
Merge branch 'main' into existing-scc
jor2 fd1b04b
fix: update value
0d3dd27
Update pr_test.go
jor2 f62c94b
fix: tests
92f9ff7
Merge branch 'main' into existing-scc
jor2 fb3309d
Merge branch 'main' into existing-scc
jor2 0ee13f4
Merge branch 'main' into existing-scc
jor2 6cd7249
fix: tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,6 +123,9 @@ func TestProjectsExistingResourcesTest(t *testing.T) { | |
| "existing_secrets_manager_crn": terraform.Output(t, existingTerraformOptions, "secrets_manager_instance_crn"), | ||
| "secret_manager_iam_engine_enabled": true, | ||
| "existing_kms_instance_crn": permanentResources["hpcs_south_crn"], | ||
| "existing_scc_instance_crn": terraform.Output(t, existingTerraformOptions, "existing_scc_instance_crn"), | ||
| "existing_cos_instance_crn": terraform.Output(t, existingTerraformOptions, "existing_cos_instance_crn"), | ||
| "existing_scc_cos_bucket_name": terraform.Output(t, existingTerraformOptions, "existing_scc_cos_bucket_name"), | ||
| "en_email_list": []string{"[email protected]"}, | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.