Skip to content

ci: secrets manager regions #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

ci: secrets manager regions #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f48bb8
ci: sm regions
alex-reiff Sep 6, 2024
82f423b
Merge branch 'main' into sm-regions
alex-reiff Sep 10, 2024
1b2188e
ci: catalog region
alex-reiff Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion catalogValidationValues.json.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"ibmcloud_api_key": $VALIDATION_APIKEY,
"prefix": $PREFIX,
"existing_resource_group_name": $RG_NAME,
"enable_platform_logs_metrics": false
"enable_platform_logs_metrics": false,
"region": "eu-de"
}
2 changes: 1 addition & 1 deletion tests/pr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ const yamlLocation = "../common-dev-assets/common-go-assets/common-permanent-res
var permanentResources map[string]interface{}

// Current supported regions (NOTE: eu-es is not being used as we don't have extended trial plan quota in that region currently)
// us-south is not being used as we have been asked to not run secrets manager tests in us-south, us-east
var validRegions = []string{
"us-south",
"eu-de",
}

Expand Down