Skip to content

Rename enable_platform_logs_metrics var #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Rename enable_platform_logs_metrics var #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18ab99f
fix: rename variable
kierramarie Feb 26, 2025
cff9707
fix: update var name in ibm_catalog.json
kierramarie Feb 26, 2025
b0baf10
Merge branch 'main' into ks-rename-var
kierramarie Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion catalogValidationValues.json.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@
"ibmcloud_api_key": $VALIDATION_APIKEY,
"prefix": $PREFIX,
"existing_resource_group_name": $RG_NAME,
"enable_platform_logs_metrics": false,
"region": "eu-de"
}
2 changes: 1 addition & 1 deletion ibm_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@
}
},
{
"key": "enable_platform_logs_metrics",
"key": "enable_platform_metrics",
"type": "boolean",
"default_value": true,
"description": "Setting this to true will create a tenant in the same region where the Cloud Logs instance is provisioned, enabling platform logs for that region. Note: You can have only one tenant per region in an account. This variable will also enable platform logs for the Log Analysis instance and platform metrics for Cloud Monitoring instance.",
Expand Down
8 changes: 2 additions & 6 deletions stack_definition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"custom_config": {}
},
{
"name": "enable_platform_logs_metrics",
"name": "enable_platform_metrics",
"required": false,
"type": "boolean",
"hidden": false,
Expand Down Expand Up @@ -166,13 +166,9 @@
"name": "existing_cos_instance_crn",
"value": "ref:../../members/1b - Object storage/outputs/cos_instance_id"
},
{
"name": "enable_platform_logs",
"value": "ref:../../inputs/enable_platform_logs_metrics"
},
{
"name": "enable_platform_metrics",
"value": "ref:../../inputs/enable_platform_logs_metrics"
"value": "ref:../../inputs/enable_platform_metrics"
},
{
"name": "existing_en_instance_crn",
Expand Down