Skip to content

Added service dropdown picker with null support to the platform_resource widget #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocofaigh merged 5 commits into from
Dec 9, 2025
Merged

Added service dropdown picker with null support to the platform_resource widget #271

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
874b991
Added service dropdown picker with null support to the platform_resou…
Dec 4, 2025
892bdc5
Merge branch 'main' into issue_16407
Khuzaima05 Dec 4, 2025
e7d9ff1
updated display name
Dec 9, 2025
b34a998
resolve review comments
Dec 9, 2025
55c484f
Merge branch 'main' into issue_16407
ocofaigh Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions ibm_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@
},
{
"key": "existing_event_notifications_instance_crn",
"display_name": "existing_event_notifications_instance",
"type": "string",
"default_value": "__NULL__",
"description": "The CRN of existing event notification instance. If not supplied, a new instance is created.",
Expand All @@ -320,10 +321,21 @@
"description": "The value provided for 'existing_event_notifications_instance_crn' is not valid.",
"value": "^__NULL__$|^crn:(.*:){3}event-notifications:(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"
}
]
],
"custom_config": {
"type": "platform_resource",
"grouping": "deployment",
"original_grouping": "deployment",
"config_constraints": {
"resourceType": "event-notifications",
"selection": "single_select",
"valueType": "crn"
}
}
},
{
"key": "existing_secrets_manager_crn",
"display_name": "existing_secrets_manager",
Copy link
Contributor

@ocofaigh ocofaigh Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually for consistency, lets go with existing_secrets_manager_instance

Copy link
Member Author

@Khuzaima05 Khuzaima05 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"type": "string",
"default_value": "__NULL__",
"description": "The CRN of an existing IBM Cloud Secrets Manager instance to use in this solution. If not set, a new Secrets Manager instance is provisioned.",
Expand All @@ -334,7 +346,17 @@
"description": "The value provided for 'existing_secrets_manager_crn' is not valid.",
"value": "^__NULL__$|^crn:(.*:){3}secrets-manager:(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"
}
]
],
"custom_config": {
"type": "platform_resource",
"grouping": "deployment",
"original_grouping": "deployment",
"config_constraints": {
"resourceType": "secrets-manager",
"selection": "single_select",
"valueType": "crn"
}
}
},
{
"key": "secrets_manager_service_plan",
Expand Down