feat: add account infrastructure base for resource group creation #53
Conversation
|
/run pipeline |
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
some comments. My concern is that the COS instance is getting created in the Observability group, but its being used by Event Notifications and SCC. But I might see if I can add a COS member its the stack here
| "resource_group_name": $PREFIX, | ||
| "audit_resource_group_name": "{{PREFIX}}-audit", | ||
| "observability_resource_group_name": "{{PREFIX}}-observability", | ||
| "security_resource_group_name": "{{PREFIX}}-security", |
There was a problem hiding this comment.
what your trying to do here is not supported. However since a prefix value is added to these groups, you can just add any text in here and prefix value will ensure they are unique for every test, so they dont clash
| "key": "audit_resource_group_name", | ||
| "type": "string", | ||
| "default_value": "__NULL__", | ||
| "required": true |
| { | ||
| "key": "observability_resource_group_name", | ||
| "type": "string", | ||
| "default_value": "__NULL__", |
| "required": true | ||
| }, | ||
| { | ||
| "key": "security_resource_group_name", |
vburckhardt
left a comment
vburckhardt
left a comment
There was a problem hiding this comment.
Let's park this PR for the initial release to get it right. I'd suggest to have the initial stack version deploy only to existing resource group.
| "default": false, | ||
| "description": "Whether to use an existing resource group.", | ||
| "default": "us-south", | ||
| "description": "The region to deploy the Deployable Architecture", |
There was a problem hiding this comment.
The region in which all resources are deployed.
| "outputs": [ | ||
| { | ||
| "key": "audit_resource_group_name", | ||
| "description": "The Name of the audit Resource Group." |
There was a problem hiding this comment.
This would need to follow our editorial guidelines -
something like: "The name of the resource group that is created by this solution. The actual name is prefixed with the value of the input 'prefix'. All resources created by this solution are deployed in this resource group. "
|
No plans to implement |
Description
Adds a new layer for the account infrastructure base and creates the audit, observability, and security resource groups based on what is set then passes that to the subsequent layers
NOTE:
due to existing resource group currently only being for the observability resource group in the account infrastructure base the input for existing resource group is removed, though we should be able to add the functionality to provide existing resource groups there
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers