Add Event routing account settings variation #48

arya-girish-k · 2025-07-07T15:47:06Z

Description

https://github.ibm.com/GoldenEye/issues/issues/14605

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

arya-girish-k · 2025-07-09T04:14:05Z

/run pipeline

ocofaigh

I think all the comment I left in terraform-ibm-modules/terraform-ibm-cloud-monitoring#51 are also applicable in this Pr - please update

ibm_catalog.json

arya-girish-k · 2025-07-21T06:56:11Z

I think all the comment I left in terraform-ibm-modules/terraform-ibm-cloud-monitoring#51 are also applicable in this Pr - please update

Updated.

arya-girish-k · 2025-07-21T07:00:22Z

/run pipeline

arya-girish-k · 2025-07-21T07:26:37Z

/run pipeline

arya-girish-k · 2025-07-22T07:10:29Z

/run pipeline

ocofaigh

see comments

ibm_catalog.json

solutions/event-routing-account-settings/catalogValidationValues.json.template

ocofaigh · 2025-07-22T10:25:05Z

solutions/event-routing-account-settings/variables.tf

+}
+
+variable "metadata_region_primary" {
+  description = "Storage location for target, route, and settings metadata in your IBM Cloud account. To store all configuration metadata in a single region, set this value explicitly. For new accounts, creating targets and routes will fail until `metadata_region_primary` is set. If set to `null`, no change is made to the current value."


For new accounts, creating targets and routes will fail until metadata_region_primary is set.

^ Are you sure about this?? I thought this was only for Metrics routing? Please test and confirm

Removed this description,since it is an required string ,I have provided default_value="us-south"

solutions/event-routing-account-settings/variables.tf

arya-girish-k · 2025-07-23T06:25:13Z

/run pipeline

arya-girish-k · 2025-07-23T08:46:31Z

/run pipeline

arya-girish-k · 2025-07-23T10:29:16Z

Tests fails with this error and unrelated to my change,Investigating the same:

         2025/07/23 09:48:55 Terraform apply | 	status code: 400, request id: 333efacb-a894-410d-a5df-3ba6f65796d0, host id: 
         2025/07/23 09:48:55 Terraform apply | 
         2025/07/23 09:48:55 Terraform apply |   with module.cos_bucket[0].module.buckets["at-fc-upg-aep-at-events-cos-bucket"].ibm_cos_bucket.cos_bucket[0],
         2025/07/23 09:48:55 Terraform apply |   on .terraform/modules/cos_bucket/main.tf line 122, in resource "ibm_cos_bucket" "cos_bucket":
         2025/07/23 09:48:55 Terraform apply |  122: resource "ibm_cos_bucket" "cos_bucket" {
         2025/07/23 09:48:55 Terraform apply | 
         2025/07/23 09:48:55 Terraform apply | ---
         2025/07/23 09:48:55 Terraform apply | id: terraform-d2853781
         2025/07/23 09:48:55 Terraform apply | summary: "InvalidRequest: Server Side Encryption with hs-crypto is not
         2025/07/23 09:48:55 Terraform apply | enabled.\n\tstatus
         2025/07/23 09:48:55 Terraform apply |   code: 400, request id: 333efacb-a894-410d-a5df-3ba6f65796d0, host id: "
         2025/07/23 09:48:55 Terraform apply | severity: error
         2025/07/23 09:48:55 Terraform apply | resource: ibm_cos_bucket
         2025/07/23 09:48:55 Terraform apply | operation: create
         2025/07/23 09:48:55 Terraform apply | component:
         2025/07/23 09:48:55 Terraform apply |   name: github.com/IBM-Cloud/terraform-provider-ibm
         2025/07/23 09:48:55 Terraform apply |   version: 1.80.3
         2025/07/23 09:48:55 Terraform apply | ---
         2025/07/23 09:48:55 Terraform apply | 
         2025/07/23 09:48:55 Terraform APPLY error: Terraform APPLY errorexit status 1
         2025/07/23 09:48:55 Could not execute job: Error : Terraform APPLY errorexit status 1
         ```

arya-girish-k · 2025-07-24T04:53:56Z

/run pipeline

arya-girish-k · 2025-07-24T06:24:56Z

Tests fails with this error and unrelated to my change,Investigating the same:

         2025/07/23 09:48:55 Terraform apply | 	status code: 400, request id: 333efacb-a894-410d-a5df-3ba6f65796d0, host id: 
         2025/07/23 09:48:55 Terraform apply | 
         2025/07/23 09:48:55 Terraform apply |   with module.cos_bucket[0].module.buckets["at-fc-upg-aep-at-events-cos-bucket"].ibm_cos_bucket.cos_bucket[0],
         2025/07/23 09:48:55 Terraform apply |   on .terraform/modules/cos_bucket/main.tf line 122, in resource "ibm_cos_bucket" "cos_bucket":
         2025/07/23 09:48:55 Terraform apply |  122: resource "ibm_cos_bucket" "cos_bucket" {
         2025/07/23 09:48:55 Terraform apply | 
         2025/07/23 09:48:55 Terraform apply | ---
         2025/07/23 09:48:55 Terraform apply | id: terraform-d2853781
         2025/07/23 09:48:55 Terraform apply | summary: "InvalidRequest: Server Side Encryption with hs-crypto is not
         2025/07/23 09:48:55 Terraform apply | enabled.\n\tstatus
         2025/07/23 09:48:55 Terraform apply |   code: 400, request id: 333efacb-a894-410d-a5df-3ba6f65796d0, host id: "
         2025/07/23 09:48:55 Terraform apply | severity: error
         2025/07/23 09:48:55 Terraform apply | resource: ibm_cos_bucket
         2025/07/23 09:48:55 Terraform apply | operation: create
         2025/07/23 09:48:55 Terraform apply | component:
         2025/07/23 09:48:55 Terraform apply |   name: github.com/IBM-Cloud/terraform-provider-ibm
         2025/07/23 09:48:55 Terraform apply |   version: 1.80.3
         2025/07/23 09:48:55 Terraform apply | ---
         2025/07/23 09:48:55 Terraform apply | 
         2025/07/23 09:48:55 Terraform APPLY error: Terraform APPLY errorexit status 1
         2025/07/23 09:48:55 Could not execute job: Error : Terraform APPLY errorexit status 1
         ```

Pipeline is failing in jp-osa region as jp-osa region does not support COS association with HPCS and hence we are facing that issue with COS bucket creation in JP-OSA region.So simply hard coded the region which supports cos association with HPCS

ocofaigh

see comments

ibm_catalog.json

solutions/event-routing-account-settings/variables.tf

tests/pr_test.go

solutions/event-routing-account-settings/variables.tf

Co-authored-by: Conall Ó Cofaigh <[email protected]>

arya-girish-k · 2025-07-24T23:02:03Z

/run pipeline

arya-girish-k · 2025-07-25T09:53:07Z

/run pipeline

terraform-ibm-modules-ops · 2025-07-25T14:33:17Z

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

GitHub release
v1.2.0

Your semantic-release bot 📦🚀

ocofaigh · 2025-07-29T18:36:57Z

solutions/event-routing-account-settings/catalogValidationValues.json.template

@@ -0,0 +1,3 @@
+{
+  "ibmcloud_api_key": $VALIDATION_APIKEY"


missed this typo - fixed in #60

Arya Girish K added 3 commits July 7, 2025 21:14

Add Event routing account settings DA

aa0a7aa

update variables.tf

c035e88

Updated permissions,description,diagram

75749be

arya-girish-k marked this pull request as ready for review July 9, 2025 04:44

arya-girish-k requested review from iamar7 and shemau as code owners July 9, 2025 04:44

ocofaigh requested changes Jul 18, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

ibm_catalog.json Outdated Show resolved Hide resolved

arya-girish-k and others added 2 commits July 20, 2025 19:30

Merge branch 'main' into account-routing

0de1b3a

Addressed Review Comments

bdbd83d

fix: Update name

80534db

fix: Update provider version

a64925b

Added some files

b852656

ocofaigh requested changes Jul 22, 2025

View reviewed changes

Arya Girish K and others added 4 commits July 23, 2025 11:26

Addressed review comments

043c06a

update catalog

fe20a45

Merge branch 'main' into account-routing

3168e77

update catalog

8ddb8a8

arya-girish-k requested a review from ocofaigh July 23, 2025 07:18

Merge branch 'main' into account-routing

767b2a1

arya-girish-k and others added 2 commits July 24, 2025 09:50

Merge branch 'main' into account-routing

a46ff55

Hardcoded region

c4d711f

ocofaigh requested changes Jul 24, 2025

View reviewed changes

arya-girish-k and others added 3 commits July 24, 2025 12:18

Update ibm_catalog.json

cee2482

Co-authored-by: Conall Ó Cofaigh <[email protected]>

Addressed Review Comments

398d97c

Updated catalog

812cb3c

update test

b11f762

ocofaigh approved these changes Jul 25, 2025

View reviewed changes

ocofaigh merged commit 9f536bf into main Jul 25, 2025
2 checks passed

ocofaigh deleted the account-routing branch July 25, 2025 14:32

terraform-ibm-modules-ops added the released label Jul 25, 2025

ocofaigh reviewed Jul 29, 2025

View reviewed changes

Add Event routing account settings variation #48

Add Event routing account settings variation #48

Uh oh!

Conversation

arya-girish-k commented Jul 7, 2025

Description

Release required?

Release notes content

Run the pipeline

Checklist for reviewers

For mergers

Uh oh!

arya-girish-k commented Jul 9, 2025

Uh oh!

ocofaigh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

arya-girish-k commented Jul 21, 2025

Uh oh!

arya-girish-k commented Jul 21, 2025

Uh oh!

arya-girish-k commented Jul 21, 2025

Uh oh!

arya-girish-k commented Jul 22, 2025

Uh oh!

ocofaigh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ocofaigh Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

arya-girish-k Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arya-girish-k commented Jul 23, 2025

Uh oh!

arya-girish-k commented Jul 23, 2025

Uh oh!

arya-girish-k commented Jul 23, 2025

Uh oh!

arya-girish-k commented Jul 24, 2025

Uh oh!

arya-girish-k commented Jul 24, 2025

Uh oh!

ocofaigh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arya-girish-k commented Jul 24, 2025

Uh oh!

arya-girish-k commented Jul 25, 2025

Uh oh!

Uh oh!

terraform-ibm-modules-ops commented Jul 25, 2025

Uh oh!

ocofaigh Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants