Skip to content

feat: add new outputs #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

feat: add new outputs #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83c7954
feat: add new outputs
ocofaigh Apr 17, 2025
2f61539
test: add workaround
ocofaigh Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,11 @@ For more information on access and permissions, see <https://cloud.ibm.com/docs/

| Name | Description |
|------|-------------|
| <a name="output_app_config_account_id"></a> [app\_config\_account\_id](#output\_app\_config\_account\_id) | Account ID of the App Configuration instance |
| <a name="output_app_config_collection_ids"></a> [app\_config\_collection\_ids](#output\_app\_config\_collection\_ids) | List of IDs for the collections in the App Configuration instance |
| <a name="output_app_config_crn"></a> [app\_config\_crn](#output\_app\_config\_crn) | CRN of the App Configuration instance |
| <a name="output_app_config_guid"></a> [app\_config\_guid](#output\_app\_config\_guid) | GUID of the App Configuration instance |
| <a name="output_app_config_id"></a> [app\_config\_id](#output\_app\_config\_id) | ID of the App Configuration instance |
<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

<!-- Leave this section as is so that your module has a link to local development environment set up steps for contributors to follow -->
Expand Down
15 changes: 15 additions & 0 deletions examples/basic/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,18 @@ output "app_config_guid" {
description = "App Configuration GUID"
value = module.app_config.app_config_guid
}

output "app_config_crn" {
description = "CRN of the App Configuration instance"
value = module.app_config.app_config_crn
}

output "app_config_id" {
description = "ID of the App Configuration instance"
value = module.app_config.app_config_id
}

output "app_config_account_id" {
description = "Account ID of the App Configuration instance"
value = module.app_config.app_config_account_id
}
17 changes: 16 additions & 1 deletion examples/complete/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,29 @@ output "prefix" {

output "resource_group_name" {
description = "The name of the resource group used"
value = var.resource_group
value = module.resource_group.resource_group_name
}

output "app_config_guid" {
description = "App Configuration GUID"
value = module.app_config.app_config_guid
}

output "app_config_crn" {
description = "CRN of the App Configuration instance"
value = module.app_config.app_config_crn
}

output "app_config_id" {
description = "ID of the App Configuration instance"
value = module.app_config.app_config_id
}

output "app_config_account_id" {
description = "Account ID of the App Configuration instance"
value = module.app_config.app_config_account_id
}

output "app_config_collection_ids" {
description = "App Configuration Collection IDs"
value = module.app_config.app_config_collection_ids
Expand Down
15 changes: 15 additions & 0 deletions outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,26 @@
# Outputs
########################################################################################################################

output "app_config_crn" {
description = "CRN of the App Configuration instance"
value = ibm_resource_instance.app_config.crn
}

output "app_config_id" {
description = "ID of the App Configuration instance"
value = ibm_resource_instance.app_config.id
}

output "app_config_guid" {
description = "GUID of the App Configuration instance"
value = ibm_resource_instance.app_config.guid
}

output "app_config_account_id" {
description = "Account ID of the App Configuration instance"
value = ibm_resource_instance.app_config.account_id
}

output "app_config_collection_ids" {
description = "List of IDs for the collections in the App Configuration instance"
value = [for obj in ibm_app_config_collection.collections : obj.collection_id]
Expand Down
10 changes: 4 additions & 6 deletions tests/pr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
)

// Use existing resource group
const resourceGroup = "geretain-test-app-config"
const completeExampleDir = "examples/complete"

func setupOptions(t *testing.T, prefix string, dir string) *testhelper.TestOptions {
Expand All @@ -23,11 +22,10 @@ func setupOptions(t *testing.T, prefix string, dir string) *testhelper.TestOptio
}
rand.New(rand.NewSource(time.Now().Unix()))
options := testhelper.TestOptionsDefaultWithVars(&testhelper.TestOptions{
Testing: t,
TerraformDir: dir,
Prefix: prefix,
Region: validRegions[rand.Intn(len(validRegions))],
ResourceGroup: resourceGroup,
Testing: t,
TerraformDir: dir,
Prefix: prefix,
Region: validRegions[rand.Intn(len(validRegions))],
})
return options
}
Expand Down