fix: config aggregator trusted profile name conflicts due to default #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
Aayush-Abhyarthi
approved these changes
Jun 16, 2025
ocofaigh
requested changes
Jun 18, 2025
There was a problem hiding this comment.
Why are we doing this? This makes user consumption worse imho. If we are getting a conflict in our tests, just set to config_aggregator_trusted_profile_name = "${var.prefix}-config-aggregator-trusted-profile". Setting to null is going to mean users will end up hitting an error when they set enable_config_aggregator to true if they don't also update value of config_aggregator_trusted_profile_name. Its better to have a default value so this does not happen
|
PR not needed, test failure was old and had been resolved in #220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an error occurring occasionally in tests where the app config aggregator trusted profile name is not using the prefix, removing the default here seems to force the replacement of the name and avoids the uniqueness issues in the test
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Removed the default from the
config_aggregator_trusted_profile_namevariable, if you were previously using the defaults you can passconfig-aggregator-trusted-profileto maintain your current state without any breaking changes.Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers