feat: Add KMS and EN integration #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukulpalit-ibm
requested review from
Aayush-Abhyarthi and
MatthewLemmond
as code owners
|
/run pipeline |
ocofaigh
requested changes
Sep 8, 2025
There was a problem hiding this comment.
- Several comments - lets try be consistent with other modules please.
- I think the DA should also be creating Event Notifications destinations, topics and email (same way we do in Secrets Manager DA).
- Since KMS and EN integration is on by default in the DA - we should also enable them in the catalog validation. It means we need to run a prereq script to deploy EN and pipe it into the
catalogValidationValues.json.templatefile. We can re-use our permanent HPCS instance for KMS encryption by setting (see here as example)
6 tasks
ocofaigh
requested changes
Sep 12, 2025
| variable "event_notifications_from_email" { | ||
| type = string | ||
| description = "The email address used to send any App Configuration event coming via Event Notifications" | ||
| default = "[email protected]" |
There was a problem hiding this comment.
where is this info available just for my reference ?
|
/run pipeline |
1 similar comment
|
/run pipeline |
ocofaigh
approved these changes
Sep 15, 2025
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue for KMS
Issue for EN
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Add KMS and EN integration to app configuration
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers