Skip to content

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Sep 19, 2025

Description

  • updated DA dependencies to latest
  • Removed unused VPC from advanced example and replaed with with Scheamtics CBR zone and rule. Due to this test has been updated to run in scheamtics.
  • Test cleanup

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh ocofaigh marked this pull request as draft September 19, 2025 10:18
MatthewLemmond
MatthewLemmond previously approved these changes Sep 19, 2025
@ocofaigh ocofaigh marked this pull request as ready for review September 19, 2025 14:43
@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

The test seems to be stuck - Going to retry..

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

@MatthewLemmond or @Aayush-Abhyarthi can you please re-approve - I had to push a fix to the test, but pipelines green now

@ocofaigh ocofaigh merged commit ff31463 into main Sep 22, 2025
2 checks passed
@ocofaigh ocofaigh deleted the tests branch September 22, 2025 08:24
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants