Skip to content

Conversation

@imprateeksh
Copy link
Member

Description

This PR addresses the issue to toggle (enable/disable) the ocp console patch by using the command mentioned in the issue.

Issue addressed - #12307

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content
  • Added support to enable or disable the OCP console patch.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@imprateeksh
Copy link
Member Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work - see comments. Also lets update 1 of the examples that PR tests runs so we test the disable feature

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not disable the console in the basic example - its more likely that a production system would disable the console, so maybe do it in the fscloud example? And don't expose it as a variable to the example. Just hard code it in the main.tf of the fscloud example

@imprateeksh
Copy link
Member Author

/run pipeline

@imprateeksh
Copy link
Member Author

Lets not disable the console in the basic example - its more likely that a production system would disable the console, so maybe do it in the fscloud example? And don't expose it as a variable to the example. Just hard code it in the main.tf of the fscloud example

I will have to expose the variable in fscloud submodule in order to pass the value as false from fscloud example

@ocofaigh
Copy link
Contributor

ocofaigh commented Feb 6, 2025

Looks good - please be aware we have an support case open on the fscloud example so pipeline may fail. We may disable CBRs as a workaround. Internal issue: https://github.ibm.com/GoldenEye/issues/issues/12539

@ocofaigh ocofaigh merged commit c603b0b into main Feb 7, 2025
2 checks passed
@ocofaigh ocofaigh deleted the disable-ocp-console branch February 7, 2025 09:19
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.39.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants