-
Notifications
You must be signed in to change notification settings - Fork 15
feat: toggle ocp console patch #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work - see comments. Also lets update 1 of the examples that PR tests runs so we test the disable feature
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not disable the console in the basic example - its more likely that a production system would disable the console, so maybe do it in the fscloud example? And don't expose it as a variable to the example. Just hard code it in the main.tf of the fscloud example
|
/run pipeline |
I will have to expose the variable in |
|
Looks good - please be aware we have an support case open on the fscloud example so pipeline may fail. We may disable CBRs as a workaround. Internal issue: https://github.ibm.com/GoldenEye/issues/issues/12539 |
|
🎉 This PR is included in version 3.39.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
This PR addresses the issue to toggle (enable/disable) the ocp console patch by using the command mentioned in the issue.
Issue addressed - #12307
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers