Skip to content

Conversation

@zikra-iqbal
Copy link
Contributor

@zikra-iqbal zikra-iqbal commented Nov 13, 2025

Description

Added support for openshift-ai-addon versions:

openshift-ai 416
Supported OpenShift cluster versions: >=4.16.0 <4.18.0

openshift-ai 417
Supported OpenShift cluster versions: >=4.17.0 <4.19.0

openshift-ai 418
Supported OpenShift cluster versions: >=4.18.0 <4.20.0

Documentation link

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Added support for openshift-ai-addon versions 416 and 417.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@zikra-iqbal
Copy link
Contributor Author

Scenario-1:

ocp_version = "4.18"
"openshift-ai" = {
      version = "416"
    } 
Screenshot 2025-11-13 at 7 07 58 PM

Scenario-2:

ocp_version = "4.15"
"openshift-ai" = {
      version = "416"
    } 
Screenshot 2025-11-13 at 7 08 47 PM

Scenario-3:

ocp_version = "4.19"
"openshift-ai" = {
      version = "417"
    } 
Screenshot 2025-11-13 at 7 09 39 PM

Scenario-4:

ocp_version = "4.16"
"openshift-ai" = {
      version = "417"
    } 
Screenshot 2025-11-13 at 7 10 26 PM

@zikra-iqbal
Copy link
Contributor Author

Scenario-5:

ocp_version = "4.18"
"openshift-ai" = {
      version = "417"
    } 
Screenshot 2025-11-13 at 10 35 57 PM Screenshot 2025-11-13 at 10 33 06 PM Screenshot 2025-11-13 at 10 34 16 PM

@zikra-iqbal
Copy link
Contributor Author

Scenario-6:

ocp_version = "4.16"
"openshift-ai" = {
      version = "416"
    } 
Screenshot 2025-11-13 at 11 42 45 PM Screenshot 2025-11-13 at 11 42 08 PM Screenshot 2025-11-13 at 11 42 21 PM

@zikra-iqbal zikra-iqbal marked this pull request as ready for review November 14, 2025 03:57
@zikra-iqbal zikra-iqbal requested a review from vkuma17 as a code owner November 14, 2025 06:09
@zikra-iqbal
Copy link
Contributor Author

/run pipeline

@imprateeksh imprateeksh removed the request for review from toddgiguere November 14, 2025 09:04
@Aashiq-J
Copy link
Member

/run pipeline

@Khuzaima05
Copy link
Member

/run pipeline

@Khuzaima05 Khuzaima05 changed the title feat: Added support for openshift-ai-addon version 416 and 417 feat: Added support for openshift-ai-addon version 417 and 418 Nov 19, 2025
Copy link
Contributor

@vkuma17 vkuma17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment

@Khuzaima05
Copy link
Member

/run pipeline

@Khuzaima05
Copy link
Member

Add on test is failing :

Screenshot 2025-11-19 at 7 40 23 PM

re-running

@Khuzaima05
Copy link
Member

Again Failing with same add-on test failure un-related to this PR:

Screenshot 2025-11-20 at 12 13 43 AM

@Khuzaima05
Copy link
Member

/run pipeline

@Khuzaima05
Copy link
Member

/run pipeline

1 similar comment
@Khuzaima05
Copy link
Member

/run pipeline

@Khuzaima05
Copy link
Member

/run pipeline

@Khuzaima05
Copy link
Member

/run pipeline

@Khuzaima05
Copy link
Member

/run pipeline

1 similar comment
@Khuzaima05
Copy link
Member

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should go with this approach. Too much overhead on us. Instead there is an api we can use. Whatever api the CLI command ibmcloud oc cluster addon versions --output json is using, we should use an external data block (so its run at plan time) and create a script to validate.
It might be easier to implement in python too.

@Khuzaima05
Copy link
Member

Closing this PR, as we’ve decided not to proceed with the manual validation approach. Instead, we’ll implement an API-based solution as discussed here #866 (review) . That work will be handled under this issue: https://github.ibm.com/GoldenEye/issues/issues/16974

@Khuzaima05 Khuzaima05 closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants