-
Notifications
You must be signed in to change notification settings - Fork 15
feat: Added support for openshift-ai-addon version 417 and 418 #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
vkuma17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor comment
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should go with this approach. Too much overhead on us. Instead there is an api we can use. Whatever api the CLI command ibmcloud oc cluster addon versions --output json is using, we should use an external data block (so its run at plan time) and create a script to validate.
It might be easier to implement in python too.
|
Closing this PR, as we’ve decided not to proceed with the manual validation approach. Instead, we’ll implement an API-based solution as discussed here #866 (review) . That work will be handled under this issue: https://github.ibm.com/GoldenEye/issues/issues/16974 |












Description
Added support for
openshift-ai-addonversions:Documentation link
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Added support for
openshift-ai-addonversions416and417.Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers